Parser changes to support parsing of multi-asic device minigraph#4222
Merged
arlakshm merged 27 commits intosonic-net:masterfrom May 4, 2020
Merged
Parser changes to support parsing of multi-asic device minigraph#4222arlakshm merged 27 commits intosonic-net:masterfrom
arlakshm merged 27 commits intosonic-net:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
In case of multiasic platform, a single minigraph.xml will be present for the device. This minigraph.xml will include device specific data and internal asic specific data. The current parser assumes that the minigraph will have data specific to a single device. In a multiple asic minigraph.xml, each asic data will be modelled as a separate device. With this change, expectation is to be able to parse and generate configuration for all asics of the device.
Apart from this, port_config.ini will have a new column to provide "asic_port_name". This name be a combination of "port name in asic" and "asic name".
- How I did it
- How to verify it
Generated config_db.json before and after the parser changes for a single asic device. No change observed.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)