[bgpcfgd] bgp peer is not added successfully sometimes#4014
Closed
tylerlinp wants to merge 1 commit intosonic-net:masterfrom
Closed
[bgpcfgd] bgp peer is not added successfully sometimes#4014tylerlinp wants to merge 1 commit intosonic-net:masterfrom
tylerlinp wants to merge 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
retest vs please |
|
|
||
| def set_handler(self, key, data): | ||
| if not self.directory.path_exist("meta", "localhost/bgp_asn"): | ||
| return False |
Contributor
There was a problem hiding this comment.
I think that the change must be following:
def on_deps_change(self):
+ if not self.directory.available_deps(self.deps):
+ return
new_queue = []
for key, data in self.set_queue:
res = self.set_handler(key, data)
I'll have it on my new PR I'm currently working.
Contributor
Author
There was a problem hiding this comment.
I'd suggest to close your PR and merge #4027
OK, thanks!
Contributor
|
I'd suggest to close your PR and merge #4027 |
mssonicbld
added a commit
that referenced
this pull request
Aug 11, 2025
…atically (#23592) #### Why I did it src/sonic-utilities ``` * 63544291 - (HEAD -> 202505, origin/202505) Revert "[SPM] Rename the variable tag to docker-image-reference" (#4026) (2 days ago) [mssonicbld] * 3a849b64 - Added json support intfutil (#4023) (3 days ago) [mssonicbld] * 562fab54 - sfputil and sfpshow eeprom and DOM CLI enhancement to display data for all CMIS transceivers (#4017) (5 days ago) [mssonicbld] * c1cb1488 - [sfputil] Use host lane mask as part of rx-output enable/disable (#4018) (5 days ago) [mssonicbld] * 95fd12bc - [Mellanox][Smartswitch]Added dpu status output (#4014) (6 days ago) [mssonicbld] * 070aae09 - Fix for #23205 [Smartswitch] Issues caused due to introduction of the chassisd/sonic-utiltiies changes for consecutive admin state changes (#4015) (6 days ago) [mssonicbld] * f2e9ed47 - [SPM] Rename the variable tag to docker-image-reference (#4011) (7 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the issue #3862 (sonic-net/sonic-utilities#782).
- How I did it
Checking meta existance first in peer handler, if not then return false.
- How to verify it
Test many times by rebooting with bgp configs(with vrf or not).
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)