[Mellanox]platform api support firmware install by stephenxs · Pull Request #3931 · sonic-net/sonic-buildimage

stephenxs · 2019-12-19T09:19:50Z

- What I did
support firmware install, including CPLD and BIOS.

- How I did it
CPLD: cpldupdate
BIOS: boot to onie and update BIOS in onie and then boot to SONiC

- How to verify it
try installing CPLD/BIOS via platform api
test-install-sonic-then-update-bios.txt
test-update-cpld-gpio.txt

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

the onie-fw-update has been postfixed with ".sh" after installed on the DUT.

…m info

jleveque · 2019-12-20T22:13:17Z

Retest vs please

jleveque · 2019-12-20T22:13:20Z

Retest vsimage please

jleveque · 2020-01-15T23:23:53Z

Retest vsimage please

…taller via using the newly introduced onie_entry

liat-grozovik · 2020-01-21T13:24:00Z

@srideepDell could you please approve this PR or you have additional feedback?

nazariig

we need to improve our flows one #3935 is merged

stephenxs · 2020-01-22T01:05:10Z

@nazariig the code that take advantage of new grub variable to resolve the sonic_installer broken issue has been merged.

nazariig · 2020-01-22T10:53:55Z

platform/mellanox/onie-fw-update

+}
+
+# ONIE entry must exist in grub config
+find_onie_menuentry()


@stephenxs Since we are already use onie_entry, we do not need this anymore

jleveque

Looks good to me. Please work through comments from other reviewers.

nazariig · 2020-01-24T11:09:51Z

retest vsimage please

support firmware install, including CPLD and BIOS. CPLD: cpldupdate BIOS: boot to onie and update BIOS in onie and then boot to SONiC

…lly (#23491) #### Why I did it src/sonic-swss ``` * c87bf6c0 - (HEAD -> master, origin/master, origin/HEAD) [FC] Reduce sairedis calls by efficient caching (#3854) (6 hours ago) [Vivek] * 287461ba - [vs]: Remove non-default objects on dynamic buffer model teardown (#3931) (10 hours ago) [Nazarii Hnydyn] * 36c598cb - Make fpmsyncd capable of handling route replace semantics (#3872) (3 days ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (#24266) #### Why I did it src/sonic-swss ``` * 3ccfa629 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (#3869) (3 days ago) [Apoorv Sachan] * 2018ed33 - Add mock test for IPv4/IPv6 route add/delete (#3839) (3 days ago) [meghtony] * 47df8071 - [portsorch] Fixed port comparison logic executed every doTask for every port (#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb4 - [ssw][ha] use endpoint IP to for tunnel term acl (#3897) (3 days ago) [Jing Zhang] * 80c742c2 - [muxorch] Fix handling mux neighbors learned after route (#3937) (4 days ago) [Nikola Dancejic] * bd479539 - [Vnetorch] Ecmp vnet local routes (#3935) (7 days ago) [Leyza] * 5de59222 - [FC] Set FC delay in command line parameters (#3814) (8 days ago) [Stepan Blyshchak] * 85a06154 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (#3881) (11 days ago) [Jing Zhang] * bc40a043 - Skip flush if ring buffer is not empty or thread is not in idle (#3895) (11 days ago) [Eddie Ruan] * ab96400c - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0e - [vs]: Fix trimming test cases: avoid config consolidation (#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f366 - [vs]: Fix trimming test cases: avoid NULL OID polling (#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a7 - [ACL] Populate SAI tunnel term correctly (#3924) (2 weeks ago) [Vivek] * fb56d6da - Maximum non-zero FEC histogram bin (#3919) (2 weeks ago) [Prince George] * c87bf6c0 - [FC] Reduce sairedis calls by efficient caching (#3854) (3 weeks ago) [Vivek] * 287461ba - [vs]: Remove non-default objects on dynamic buffer model teardown (#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598cb - Make fpmsyncd capable of handling route replace semantics (#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (sonic-net#24266) #### Why I did it src/sonic-swss ``` * 3ccfa629 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (sonic-net#3869) (3 days ago) [Apoorv Sachan] * 2018ed33 - Add mock test for IPv4/IPv6 route add/delete (sonic-net#3839) (3 days ago) [meghtony] * 47df8071 - [portsorch] Fixed port comparison logic executed every doTask for every port (sonic-net#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb4 - [ssw][ha] use endpoint IP to for tunnel term acl (sonic-net#3897) (3 days ago) [Jing Zhang] * 80c742c2 - [muxorch] Fix handling mux neighbors learned after route (sonic-net#3937) (4 days ago) [Nikola Dancejic] * bd479539 - [Vnetorch] Ecmp vnet local routes (sonic-net#3935) (7 days ago) [Leyza] * 5de59222 - [FC] Set FC delay in command line parameters (sonic-net#3814) (8 days ago) [Stepan Blyshchak] * 85a06154 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (sonic-net#3881) (11 days ago) [Jing Zhang] * bc40a043 - Skip flush if ring buffer is not empty or thread is not in idle (sonic-net#3895) (11 days ago) [Eddie Ruan] * ab96400c - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (sonic-net#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0e - [vs]: Fix trimming test cases: avoid config consolidation (sonic-net#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f366 - [vs]: Fix trimming test cases: avoid NULL OID polling (sonic-net#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a7 - [ACL] Populate SAI tunnel term correctly (sonic-net#3924) (2 weeks ago) [Vivek] * fb56d6da - Maximum non-zero FEC histogram bin (sonic-net#3919) (2 weeks ago) [Prince George] * c87bf6c0 - [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (3 weeks ago) [Vivek] * 287461ba - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598cb - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (sonic-net#23491) #### Why I did it src/sonic-swss ``` * c87bf6c0 - (HEAD -> master, origin/master, origin/HEAD) [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (6 hours ago) [Vivek] * 287461ba - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (10 hours ago) [Nazarii Hnydyn] * 36c598cb - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 days ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>

…lly (sonic-net#24266) #### Why I did it src/sonic-swss ``` * 3ccfa629 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (sonic-net#3869) (3 days ago) [Apoorv Sachan] * 2018ed33 - Add mock test for IPv4/IPv6 route add/delete (sonic-net#3839) (3 days ago) [meghtony] * 47df8071 - [portsorch] Fixed port comparison logic executed every doTask for every port (sonic-net#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb4 - [ssw][ha] use endpoint IP to for tunnel term acl (sonic-net#3897) (3 days ago) [Jing Zhang] * 80c742c2 - [muxorch] Fix handling mux neighbors learned after route (sonic-net#3937) (4 days ago) [Nikola Dancejic] * bd479539 - [Vnetorch] Ecmp vnet local routes (sonic-net#3935) (7 days ago) [Leyza] * 5de59222 - [FC] Set FC delay in command line parameters (sonic-net#3814) (8 days ago) [Stepan Blyshchak] * 85a06154 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (sonic-net#3881) (11 days ago) [Jing Zhang] * bc40a043 - Skip flush if ring buffer is not empty or thread is not in idle (sonic-net#3895) (11 days ago) [Eddie Ruan] * ab96400c - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (sonic-net#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0e - [vs]: Fix trimming test cases: avoid config consolidation (sonic-net#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f366 - [vs]: Fix trimming test cases: avoid NULL OID polling (sonic-net#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a7 - [ACL] Populate SAI tunnel term correctly (sonic-net#3924) (2 weeks ago) [Vivek] * fb56d6da - Maximum non-zero FEC histogram bin (sonic-net#3919) (2 weeks ago) [Prince George] * c87bf6c0 - [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (3 weeks ago) [Vivek] * 287461ba - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598cb - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <[email protected]>

…lly (sonic-net#24266) #### Why I did it src/sonic-swss ``` * 3ccfa629 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] Add FEC frame loss ratio monitoring with predictive analytics (sonic-net#3869) (3 days ago) [Apoorv Sachan] * 2018ed33 - Add mock test for IPv4/IPv6 route add/delete (sonic-net#3839) (3 days ago) [meghtony] * 47df8071 - [portsorch] Fixed port comparison logic executed every doTask for every port (sonic-net#3821) (3 days ago) [Stepan Blyshchak] * 0c60bdb4 - [ssw][ha] use endpoint IP to for tunnel term acl (sonic-net#3897) (3 days ago) [Jing Zhang] * 80c742c2 - [muxorch] Fix handling mux neighbors learned after route (sonic-net#3937) (4 days ago) [Nikola Dancejic] * bd479539 - [Vnetorch] Ecmp vnet local routes (sonic-net#3935) (7 days ago) [Leyza] * 5de59222 - [FC] Set FC delay in command line parameters (sonic-net#3814) (8 days ago) [Stepan Blyshchak] * 85a06154 - [ssw][ha] set `SAI_ENI_ATTR_IS_HA_FLOW_OWNER` & `SAI_ENI_ATTR_HA_SCOPE_ID` when creating eni (sonic-net#3881) (11 days ago) [Jing Zhang] * bc40a043 - Skip flush if ring buffer is not empty or thread is not in idle (sonic-net#3895) (11 days ago) [Eddie Ruan] * ab96400c - [trim]: Update log level severity to avoid errors during attribute/enum capabilities query (sonic-net#3916) (2 weeks ago) [Nazarii Hnydyn] * 582eed0e - [vs]: Fix trimming test cases: avoid config consolidation (sonic-net#3939) (2 weeks ago) [Nazarii Hnydyn] * 34b9f366 - [vs]: Fix trimming test cases: avoid NULL OID polling (sonic-net#3943) (2 weeks ago) [Nazarii Hnydyn] * 8b8918a7 - [ACL] Populate SAI tunnel term correctly (sonic-net#3924) (2 weeks ago) [Vivek] * fb56d6da - Maximum non-zero FEC histogram bin (sonic-net#3919) (2 weeks ago) [Prince George] * c87bf6c0 - [FC] Reduce sairedis calls by efficient caching (sonic-net#3854) (3 weeks ago) [Vivek] * 287461ba - [vs]: Remove non-default objects on dynamic buffer model teardown (sonic-net#3931) (3 weeks ago) [Nazarii Hnydyn] * 36c598cb - Make fpmsyncd capable of handling route replace semantics (sonic-net#3872) (3 weeks ago) [venkit-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: xiaweijiang <[email protected]>

Stephen Sun added 7 commits November 21, 2019 09:53

[sonic_platform]support install firmware

2c8e646

[component.py]Address comments

80ecdaa

[component.py]address comments

f73b20b

[platform_api]add chassis.get_name, add exit code checking

b411566

[component.py]add return code check for subprocess handling

37b11ca

[component]update name: onie-fw-updated.sh

30a4ae7

the onie-fw-update has been postfixed with ".sh" after installed on the DUT.

[chassis]update the way to get the chassis name to using onie_platfor…

9477140

…m info

jleveque added Enhancement ➕ Platform: Mellanox labels Dec 20, 2019

srideepDell previously approved these changes Jan 15, 2020

View reviewed changes

[fwupdate]fix issue that setting next_entry=ONIE breaks the sonic_ins…

08d885a

…taller via using the newly introduced onie_entry

stephenxs dismissed srideepDell’s stale review via 08d885a January 17, 2020 01:28

keboliu previously approved these changes Jan 19, 2020

View reviewed changes

nazariig requested changes Jan 21, 2020

View reviewed changes

nazariig requested changes Jan 22, 2020

View reviewed changes

liat-grozovik requested a review from jleveque January 22, 2020 11:52

jleveque previously approved these changes Jan 22, 2020

View reviewed changes

[onie-fw-update]remove find_onie_menuentry.

c3fa992

stephenxs dismissed stale reviews from jleveque and keboliu via c3fa992 January 23, 2020 06:49

nazariig approved these changes Jan 23, 2020

View reviewed changes

sujinmkang approved these changes Jan 28, 2020

View reviewed changes

lguohan merged commit 33e918f into sonic-net:master Jan 29, 2020

stephenxs deleted the fwupdate branch January 29, 2020 05:57

liat-grozovik added the Request for 201911 Branch label Feb 20, 2020

abdosi pushed a commit that referenced this pull request Feb 24, 2020

[Mellanox] platform api support firmware install (#3931)

48f8a8d

support firmware install, including CPLD and BIOS. CPLD: cpldupdate BIOS: boot to onie and update BIOS in onie and then boot to SONiC

abdosi added the Included in 201911 Branch label Feb 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox]platform api support firmware install#3931

[Mellanox]platform api support firmware install#3931
lguohan merged 9 commits intosonic-net:masterfrom
stephenxs:fwupdate

stephenxs commented Dec 19, 2019

Uh oh!

jleveque commented Dec 20, 2019

Uh oh!

jleveque commented Dec 20, 2019

Uh oh!

jleveque commented Jan 15, 2020

Uh oh!

liat-grozovik commented Jan 21, 2020

Uh oh!

nazariig left a comment

Uh oh!

stephenxs commented Jan 22, 2020

Uh oh!

nazariig Jan 22, 2020

Uh oh!

stephenxs Jan 23, 2020

Uh oh!

jleveque left a comment

Uh oh!

nazariig commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

stephenxs commented Dec 19, 2019

Uh oh!

jleveque commented Dec 20, 2019

Uh oh!

jleveque commented Dec 20, 2019

Uh oh!

jleveque commented Jan 15, 2020

Uh oh!

liat-grozovik commented Jan 21, 2020

Uh oh!

nazariig left a comment

Choose a reason for hiding this comment

Uh oh!

stephenxs commented Jan 22, 2020

Uh oh!

nazariig Jan 22, 2020

Choose a reason for hiding this comment

Uh oh!

stephenxs Jan 23, 2020

Choose a reason for hiding this comment

Uh oh!

jleveque left a comment

Choose a reason for hiding this comment

Uh oh!

nazariig commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants