DellEMC: S5232 Fix transceiver change event bug#3898
Closed
aravindmani-1 wants to merge 4 commits intosonic-net:masterfrom
Closed
DellEMC: S5232 Fix transceiver change event bug#3898aravindmani-1 wants to merge 4 commits intosonic-net:masterfrom
aravindmani-1 wants to merge 4 commits intosonic-net:masterfrom
Conversation
mssonicbld
added a commit
that referenced
this pull request
May 28, 2025
…atically (#22664) #### Why I did it src/sonic-utilities ``` * 6964f652 - (HEAD -> 202505, origin/202505) add TH5-512 hwsku into gcu support list (#3898) (16 hours ago) [mssonicbld] * 1ec19bc3 - feat: support namespace arg for show bfd commands (#3892) (6 days ago) [mssonicbld] * 6f93c7ff - feat: support namespace arg for show mac (#3893) (6 days ago) [mssonicbld] * c78e0f7 - VNET CLI- ADD/DEL VNET, ADD/DEL VNET ROUTE, VRF BIND/UNBIND to consider VNET + ADDITIONAL MODIFICATIONS TO SHOW VNET CLIs (#3826) (13 days ago) [KavyaVaniBedida] * 1d6e050 - Revert "Vnet_name added in create_only patterns (#3878)" (#3879) (13 days ago) [miatttao] * 5db13c2 - skip pfcwd if disabled in golden_config (#3880) (2 weeks ago) [Dashuai Zhang] * 07b232a - Add GCU Support for SKU Mellanox-SN4280-O8C80 (#3871) (2 weeks ago) [Sai Rama Mohan Reddy S] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
xcvrd returns the following error in get_transceiver_change_event() as timeout argument is not used.
Process Process-1:
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "/usr/bin/xcvrd", line 795, in task_worker
status, port_dict = _wrapper_get_transceiver_change_event(timeout)
File "/usr/bin/xcvrd", line 158, in _wrapper_get_transceiver_change_event
return platform_sfputil.get_transceiver_change_event(timeout)
TypeError: get_transceiver_change_event() takes exactly 1 argument (2 given
- How I did it
Use timeout argument in get_transceiver_change_event().
- How to verify it
Run xcvrd and check whether any error is returned.
- Description for the changelog
Use timeout argument in get_transceiver_change_event() as xcvrd passes the timeout value.