[Inventec][D6332] Add new platform Inventec D6332 by david-xk · Pull Request #3769 · sonic-net/sonic-buildimage

david-xk · 2019-11-15T22:45:31Z

- What I did

Add D6332 device files
Add D6332 driver files
Add D6332 Platform API implementation
Modify Makefile, debian rules and add init scripts

- How I did it

Add D6332 device files to device/inventec/x86_64-inventec_d6332-r0/
Add D6332 driver files to platform/broadcom/sonic-platform-modules-inventec/d6332/modules/
Add D6332 Platform API implementation to platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform
Modify Makefile, debian rules and add init scripts in platform/broadcom/sonic-platform-modules-inventec/

- How to verify it

check drivers: lsmod |grep -E "^inv_"
check platform eeprom: show platform syseeprom
check platform PSUs: show platform psustatus
check interface status: show interfaces status
check transceiver presence: show interfaces transceiver presence

- Description for the changelog

Nov 15, 2019 initial commit
- Add D6332 device files
- Add D6332 driver files
- Add D6332 Platform API implementation
- Modify Makefile, debian rules and add init scripts

- A picture of a cute animal (not mandatory but encouraged)

1. Add D6332 device files device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/buffers.json.j2 device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/buffers_defaults_t0.j2 device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/buffers_defaults_t1.j2 device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/pg_profile_lookup.ini device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/port_config.ini device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/qos.json.j2 device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/sai.profile device/inventec/x86_64-inventec_d6332-r0/INVENTEC-D6332/td3-d6332-32x100G.config.bcm device/inventec/x86_64-inventec_d6332-r0/custom_led.bin device/inventec/x86_64-inventec_d6332-r0/default_sku device/inventec/x86_64-inventec_d6332-r0/installer.conf device/inventec/x86_64-inventec_d6332-r0/led_proc_init.soc device/inventec/x86_64-inventec_d6332-r0/linkscan_led_fw.bin device/inventec/x86_64-inventec_d6332-r0/plugins/eeprom.py device/inventec/x86_64-inventec_d6332-r0/sensors.conf 2. Add D6332 Driver platform/broadcom/sonic-platform-modules-inventec/d6332/modules/Makefile platform/broadcom/sonic-platform-modules-inventec/d6332/modules/gpio-ich.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/i2c-mux-pca9541.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_cpld.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_eeprom.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_mux.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_mux.h platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_platform.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_swps.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/inv_swps.h platform/broadcom/sonic-platform-modules-inventec/d6332/modules/io_expander.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/io_expander.h platform/broadcom/sonic-platform-modules-inventec/d6332/modules/lpc_ich.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/pmbus.h platform/broadcom/sonic-platform-modules-inventec/d6332/modules/transceiver.c platform/broadcom/sonic-platform-modules-inventec/d6332/modules/transceiver.h platform/broadcom/sonic-platform-modules-inventec/d6332/modules/ucd9000.c 3. Add New Platform API implementation platform/broadcom/sonic-platform-modules-inventec/d6332/setup.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/__init__.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/chassis.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/eeprom.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/fan.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/platform.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/psu.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/qsfp.py platform/broadcom/sonic-platform-modules-inventec/d6332/sonic_platform/thermal.py 4. Modify Makefile, debian rules and add init scripts platform/broadcom/one-image.mk platform/broadcom/platform-modules-inventec.mk platform/broadcom/sonic-platform-modules-inventec/debian/control platform/broadcom/sonic-platform-modules-inventec/debian/platform-modules-d6332.init platform/broadcom/sonic-platform-modules-inventec/debian/platform-modules-d6332.install platform/broadcom/sonic-platform-modules-inventec/debian/rules platform/broadcom/sonic-platform-modules-inventec/systemd/platform-modules-d6332.service Signed-off-by: David Xiao <[email protected]>

Signed-off-by: David Xiao <[email protected]>

add sfputil.py to plugins Signed-off-by: David Xiao <[email protected]>

david-xk · 2020-01-17T19:06:13Z

@jleveque Hi Joe, would you please review this PR at your convenience? Thanks a lot.

device/inventec/x86_64-inventec_d6332-r0/led_proc_init.soc

Signed-off-by: David Xiao <[email protected]>

platform/broadcom/sonic-platform-modules-inventec/debian/platform-modules-d6332.init

Signed-off-by: David Xiao <[email protected]>

jleveque

Looks good to me. I would just like Guohan to look it over, as well.

david-xk · 2020-01-19T00:44:30Z

@jleveque Hi Joe, thanks a lot for spending time to review this PR, much appreciated. Would you please review another PR #3839 at your convenience? Have a great weekend.

david-xk · 2020-02-10T20:08:55Z

@lguohan Hi Guohan, Joe asked for second review for this PR, would you please take a look at your convenience. Thanks a lot. Best, David

david-xk · 2020-02-19T16:05:13Z

@jleveque Hi Joe, it looks like Guohan hasn't get a chance to look into this PR in past several weeks. Would you please kindly touch base with him and see what should we process this PR. Many thanks. Best, David

lguohan · 2020-05-21T09:04:29Z

platform/broadcom/sonic-platform-modules-inventec/debian/control


+Package: platform-modules-d6332
+Architecture: amd64
+Depends: linux-image-4.9.0-9-2-amd64


4.19 kernel

lguohan · 2020-05-21T09:04:42Z

platform/broadcom/sonic-platform-modules-inventec/debian/control

@@ -30,6 +30,11 @@ Architecture: amd64
 Depends: linux-image-4.9.0-9-2-amd64


4.19 kernel

lguohan · 2020-05-21T09:05:58Z

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/ucd9000.c

@@ -0,0 +1,247 @@
+/*
+ * Hardware monitoring driver for UCD90xxx Sequencer and System Health


why not use original kernel driver?

lguohan · 2020-05-21T09:06:42Z

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/transceiver.c

@@ -0,0 +1,8409 @@
+#include <linux/slab.h>


please use optoe driver.

lguohan · 2020-05-21T09:06:59Z

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/pmbus.h

@@ -0,0 +1,425 @@
+/*


use linux original driver

lguohan · 2020-05-21T09:07:17Z

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/lpc_ich.c

@@ -0,0 +1,1131 @@
+/*
+ *  lpc_ich.c - LPC interface for Intel ICH


use linux original driver.

lguohan · 2020-05-21T09:09:44Z

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/i2c-mux-pca9541.c

@@ -0,0 +1,573 @@
+/*
+ * I2C multiplexer driver for PCA9541 bus master selector


use linux original driver

lguohan · 2020-05-21T09:10:00Z

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/gpio-ich.c

@@ -0,0 +1,513 @@
+/*
+ * Intel ICH6-10, Series 5 and 6, Atom C2000 (Avoton/Rangeley) GPIO driver


use linux original driver.

lguohan

use linux original driver

…atically (#22026) #### Why I did it src/sonic-utilities ``` * 6e93f44 - (HEAD -> master, origin/master, origin/HEAD) Add Arista-7060X6-64PE-C224O8, Arista-7060X6-64PE-C256S2 to generic_config_updater (#3804) (18 hours ago) [rick-arista] * 208474c - Add scope to field validator.[redo PR: 3675] (#3805) (2 days ago) [Xincun Li] * a363c7f - [SmartSwitch] Extend reboot script for rebooting SmartSwitch (#3566) (6 days ago) [Vasundhara Volam] * 5e3b132 - [hash] update GH frontend with IPV6_FLOW_LABEL for ECMP/LAG switch hash configuration (#3730) (7 days ago) [Andriy Yurkiv] * 706f97e - [Techsupport] Add show route-map command to frr dumps in techsupport (#3797) (7 days ago) [Sudharsan Dhamal Gopalarathnam] * 1ec0540 - Fix the switch level Voq counter to use switch_id Oid instead of counter name for PACKET_INTEGRITY counter (#3769) (7 days ago) [saksarav-nokia] ``` #### How I did it #### How to verify it #### Description for the changelog

jleveque added Enhancement ➕ Platform: Inventec labels Nov 25, 2019

David Xiao added 3 commits November 26, 2019 15:54

skip ledd to avoid pmon docker startup failure

7edeed4

Signed-off-by: David Xiao <[email protected]>

[Platform API] Add get_change_event implementation for Chassis class

d10f4b1

Signed-off-by: David Xiao <[email protected]>

add serdes inteface type in bcm configuraion

c47f542

add sfputil.py to plugins Signed-off-by: David Xiao <[email protected]>

jleveque suggested changes Jan 17, 2020

View reviewed changes

device/inventec/x86_64-inventec_d6332-r0/led_proc_init.soc Outdated Show resolved Hide resolved

remove commented lines in led_proc_init.soc

18e1351

Signed-off-by: David Xiao <[email protected]>

jleveque suggested changes Jan 18, 2020

View reviewed changes

platform/broadcom/sonic-platform-modules-inventec/debian/platform-modules-d6332.init Outdated Show resolved Hide resolved

replace tab with 4 spaces in platform-modules-d6332.init

85bfa2f

Signed-off-by: David Xiao <[email protected]>

jleveque approved these changes Jan 18, 2020

View reviewed changes

jleveque requested a review from lguohan January 18, 2020 01:42

lguohan reviewed May 21, 2020

View reviewed changes

platform/broadcom/sonic-platform-modules-inventec/d6332/modules/pmbus.h

@@ -0,0 +1,425 @@

/*

Copy link

Collaborator

lguohan May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use linux original driver

lguohan reviewed May 21, 2020

View reviewed changes

lguohan requested changes May 21, 2020

View reviewed changes

david-xk closed this Jul 23, 2020

		@@ -30,6 +30,11 @@ Architecture: amd64
		Depends: linux-image-4.9.0-9-2-amd64

		@@ -0,0 +1,247 @@
		/*
		* Hardware monitoring driver for UCD90xxx Sequencer and System Health

		@@ -0,0 +1,1131 @@
		/*
		* lpc_ich.c - LPC interface for Intel ICH

		@@ -0,0 +1,573 @@
		/*
		* I2C multiplexer driver for PCA9541 bus master selector

		@@ -0,0 +1,513 @@
		/*
		* Intel ICH6-10, Series 5 and 6, Atom C2000 (Avoton/Rangeley) GPIO driver

Conversation

david-xk commented Nov 15, 2019

Uh oh!

david-xk commented Jan 17, 2020

Uh oh!

Uh oh!

Uh oh!

jleveque left a comment

Choose a reason for hiding this comment

Uh oh!

david-xk commented Jan 19, 2020

Uh oh!

david-xk commented Feb 10, 2020

Uh oh!

david-xk commented Feb 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants