Skip to content

[bgpcfgd]: Avoid crashing bgpcfgd when render of bgpd.peer.conf.j2 has issues#3668

Merged
lguohan merged 1 commit intosonic-net:masterfrom
pavel-shirshov:pavelsh/fix_render
Oct 29, 2019
Merged

[bgpcfgd]: Avoid crashing bgpcfgd when render of bgpd.peer.conf.j2 has issues#3668
lguohan merged 1 commit intosonic-net:masterfrom
pavel-shirshov:pavelsh/fix_render

Conversation

@pavel-shirshov
Copy link
Contributor

- What I did
Fix a possibility to crash bgpcfgd by incorrect j2 template
- How I did it
Add try catch block
- How to verify it

  1. Delete existing bgp peer: DEL BGP_PEER|10.0.0.1
  2. Change properties for the deleted peer: hset BGP_PEER|10.0.0.1 admin up

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov
Copy link
Contributor Author

retest vs please

@lguohan lguohan merged commit 3a78709 into sonic-net:master Oct 29, 2019
mssonicbld added a commit that referenced this pull request Dec 11, 2024
…atically (#21128)

#### Why I did it
src/sonic-utilities
```
* d5cbe46 - (HEAD -> master, origin/master, origin/HEAD) [GCU] Add data acl table and rule check (#3668) (3 minutes ago) [jingwenxie]
```
#### How I did it
#### How to verify it
#### Description for the changelog
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…atically (sonic-net#21128)

#### Why I did it
src/sonic-utilities
```
* d5cbe46 - (HEAD -> master, origin/master, origin/HEAD) [GCU] Add data acl table and rule check (sonic-net#3668) (3 minutes ago) [jingwenxie]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jun 6, 2025
…lly (#22790)

#### Why I did it
src/sonic-swss
```
* 5e07127 - (HEAD -> master, origin/master, origin/HEAD) [dashhaorch]: Fix error: stack protector not protecting local variables: variable length buffer (#3643) (4 hours ago) [Nazarii Hnydyn]
* d589d8d - [swss]: IcmpOrch to support ICMP session offload to ASIC (#3535) (6 hours ago) [manamand2020]
* f05e8e9 - [SRv6] add MySID counters support (#3601) (6 hours ago) [Yakiv Huryk]
* a0bd39e - Skip "port doesn't exist" SWSS_LOG_INFO messages for local ports (#3553) (31 hours ago) [HP]
* 74b2cc6 - [ci]: Skip publishing of asan vstest summary (#3669) (32 hours ago) [prabhataravind]
* 398161b - [Dynamic Buffer][Mellanox] Fix an issue when handling 2-digit queue ID in the Lua plugin (#3588) (2 days ago) [Stephen Sun]
* 7106cc0 - Fixing macsecmgrd memory corruption (#3611) (2 days ago) [sivanuka-arista]
* e830a49 - [fpmsyncd]Fixing blackhole route to publish protocol field to APPL_DB (#3655) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
* de5b8e5 - Setting default nexthop weight to 1 in `fpmsyncd` (#3636) (3 days ago) [mramezani95]
* 176bcea - Change Log Level for BFD Offload Capability Implementation (#3641) (3 days ago) [Sai Rama Mohan Reddy S]
* f9f7ff0 - Fix NextHopGroupEntry class data member not initialized bug (#3644) (3 days ago) [Hua Liu]
* c8c597c - Install symlink to Python 3 to work around AzP diff coverage issue (#3670) (6 days ago) [Saikrishna Arcot]
* 3a5efa3 - [tests]: Fix `test_MirrorDestMoveLag` test failure (#3639) (6 days ago) [Carmine Scarpitta]
* 13d559d - Revert "Set Port UPDATE_DSCP attribute when TC_TO_DSCP map is attached (#3517)" (#3666) (6 days ago) [Kumaresh Perumal]
* 1c601cb - Changes to unblock swss pipeline tests (#3664) (7 days ago) [prabhataravind]
* b31500b - [build] Support optionally using other container registries instead of DockerHub (#3668) (7 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants