Skip to content

[build_debuian]: Fix issue #267 (docker connect failure). #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 1 commit into from
Mar 3, 2017
Merged

[build_debuian]: Fix issue #267 (docker connect failure). #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion files/build_templates/sonic_debian_extension.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ trap_push clean_sys
sudo LANG=C chroot $FILESYSTEM_ROOT mount sysfs /sys -t sysfs

sudo chroot $FILESYSTEM_ROOT service docker start
sudo chroot $FILESYSTEM_ROOT docker version

Copy link
Copy Markdown
Collaborator

@lguohan lguohan Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide explaination?

Copy link
Copy Markdown
Collaborator Author

@oleksandrivantsiv oleksandrivantsiv Mar 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker version command gets information from docker engine via socket. Service runs docker engine but it doesn't wait until docker engine will be fully initialized. In some cases docker version command was run before docker was fully initialized. Actually we don't need in a build time information that docker version command returns so I just removed execution of this command.

I've run build of sonic-mellanox.bin target for 50 times with this patch and issue wasn't reproduced.

# Apply apt configuration files
sudo cp $IMAGE_CONFIGS/apt/sources.list $FILESYSTEM_ROOT/etc/apt/
Expand Down