Skip to content

[docker_image_ctl.j2] skip hostname update if is up to date - #3529

Merged
jleveque merged 1 commit into
sonic-net:masterfrom
stepanblyschak:skip_hostname_if_uptodate
Oct 2, 2019
Merged

[docker_image_ctl.j2] skip hostname update if is up to date#3529
jleveque merged 1 commit into
sonic-net:masterfrom
stepanblyschak:skip_hostname_if_uptodate

Conversation

@stepanblyschak

Copy link
Copy Markdown
Collaborator

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

- What I did
Skip container hostname update in case container hostname is up to date.
This improves LAG restoration time during warm reboot by 10 seconds.

- How I did it
Implement a condition

- How to verify it

admin@r-boxer-sw01:~$ docker exec -it lldp hostname
r-boxer-sw01
admin@r-boxer-sw01:~$ redis-cli -n 4 hset 'DEVICE_METADATA|localhost' hostname sonic
admin@r-boxer-sw01:~$ sudo lldp.sh stop
admin@r-boxer-sw01:~$ sudo lldp.sh start
admin@r-boxer-sw01:~$ docker exec -it lldp hostname
sonic

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@jleveque

Copy link
Copy Markdown
Contributor

Retest vsimage please

1 similar comment
@jleveque

Copy link
Copy Markdown
Contributor

Retest vsimage please

@stepanblyschak

Copy link
Copy Markdown
Collaborator Author

Retest vsimage please

2 similar comments
@jleveque

Copy link
Copy Markdown
Contributor

Retest vsimage please

@jleveque

jleveque commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

Retest vsimage please

@jleveque
jleveque merged commit 52e35a0 into sonic-net:master Oct 2, 2019
@stepanblyschak
stepanblyschak deleted the skip_hostname_if_uptodate branch September 23, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants