Add daemon which periodically pushes process and docker stats to State DB by pra-moh · Pull Request #3525 · sonic-net/sonic-buildimage

pra-moh · 2019-09-26T23:39:55Z

- What I did
Adding daemon which every 2 mins uploads docker and process stats data to state db
- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

files/image_config/procdockerstats/procdockerstats

files/image_config/procdockerstats/procdockerstats.service

files/image_config/procdockerstats/procdockerstats

hui-ma

LGTM. Will this demon be started automatically. And if it crash, how will it be restarted?

files/image_config/procdockerstats/procdockerstats

hui-ma · 2019-10-25T22:09:01Z

Some questions:
Is this daemon enabled automatically?
If it crash, how to resume it?

jleveque · 2019-10-25T22:14:02Z

@hui-ma: For the daemon to get included in the image and started automatically, Pradnya will need to add it to files/build_templates/sonic_debian_extension.j2.

To have the daemon auto-restart upon crash, she will need to add the line Restart=always to the [Service] section of the service file.

hui-ma · 2019-10-25T22:24:44Z

@jleveque Thanks for the info of files/build_templates/sonic_debian_extension.j2.. Let us do another PR for it later.

jleveque · 2019-10-25T22:26:45Z

@hui-ma: I believe that change should be part of this PR. It is a small change, and I can help Pradnya.

files/image_config/procdockerstats/procdockerstats

…ame in redis

files/image_config/procdockerstats/procdockerstats

adding more descriptive names line indented returning explicitly none

files/image_config/procdockerstats/procdockerstats

files/image_config/procdockerstats/procdockerstats.service

changed comment for daemon

files/image_config/procdockerstats/procdockerstats

rearrange imports based on comment

files/image_config/procdockerstats/procdockerstats

jleveque

I suggest appending a 'd' to the name of the daemon to follow the naming convention which signifies this application runs as a daemon (e.g., "procdockerstatsd").

pra-moh · 2019-11-21T22:09:46Z

I suggest appending a 'd' to the name of the daemon to follow the naming convention which signifies this application runs as a daemon (e.g., "procdockerstatsd").

done

files/image_config/procdockerstatsd/procdockerstatsd

jleveque · 2019-11-25T21:00:20Z

Retest broadcom please

files/build_templates/sonic_debian_extension.j2

files/image_config/procdockerstatsd/procdockerstatsd.service

adding process/docker in comment

jleveque · 2019-11-27T05:02:19Z

Retest vs please

jleveque · 2019-11-27T05:02:28Z

Retest vsimage please

jleveque · 2019-11-27T23:35:34Z

vsimage check build failure is unrelated. Merging PR in spite of this failure.

…e DB (sonic-net#3525)

…atically (#20220) #### Why I did it src/sonic-utilities ``` * e99077a4 - (HEAD -> 202405, origin/202405) Fix ntp conf file path (#3525) (54 minutes ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog

…atically (#20202) #### Why I did it src/sonic-utilities ``` * a7897d1 - (HEAD -> master, origin/master, origin/HEAD) [show][interface][counters] Add proposal and changes for fec-histogram for interface counters fec-histogram subcommand (#3519) (10 hours ago) [vdahiya12] * 5fdc1b6 - [Mellanox] Add new SKU Mellanox-SN5600-C256 (#3431) (34 hours ago) [DavidZagury] * d103bfd - Fix ntp conf file path (#3525) (34 hours ago) [Vivek] * 5eb266a - [chassis] Modify the show ip route to hide the Ethernet-IB port in the output (#3537) (34 hours ago) [Arvindsrinivasan Lakshmi Narasimhan] ``` #### How I did it #### How to verify it #### Description for the changelog

adding draft for daemon getting process data

d0f36ee

jleveque suggested changes Sep 27, 2019

View reviewed changes

jleveque added the Enhancement ➕ label Sep 27, 2019

resolving PR comments, adding separate method for docker

58b59dc

jleveque suggested changes Sep 30, 2019

View reviewed changes

pra-moh added 2 commits October 1, 2019 13:19

adjusting whitespace

d5cf0f0

adding process data output parsing to daemon

b085b5b

jleveque suggested changes Oct 2, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

adjusting space

9624514

pra-moh marked this pull request as ready for review October 2, 2019 22:38

jleveque suggested changes Oct 5, 2019

View reviewed changes

pra-moh added 3 commits October 7, 2019 12:08

removing trailing spaces

f1b2d8a

adding seperate method for docker data formatting

57da086

uncommenting root check

9119ba9

jleveque suggested changes Oct 25, 2019

View reviewed changes

hui-ma reviewed Oct 25, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

resolving comments on constant name, rounded integer

cd49b30

jleveque suggested changes Nov 13, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

pra-moh added 2 commits November 13, 2019 14:58

Resolving comment for converting to integer and uppercase for table n…

a56b356

…ame in redis

adding restart=always

8d0ef54

jleveque suggested changes Nov 13, 2019

View reviewed changes

adding entry in sonic_debian_extension.j2

0c51c28

adding more descriptive names line indented returning explicitly none

jleveque suggested changes Nov 14, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

files/image_config/procdockerstats/procdockerstats.service Outdated Show resolved Hide resolved

added new line at end of file

147719f

changed comment for daemon

jleveque suggested changes Nov 14, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

jleveque reviewed Nov 14, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Show resolved Hide resolved

pra-moh added 2 commits November 13, 2019 17:40

uppercase for process and docker_stats

b00378d

rearrange imports based on comment

trying to add changes from previous commit

57c33ed

jleveque suggested changes Nov 14, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

correcting return statement

e2f147d

jleveque suggested changes Nov 16, 2019

View reviewed changes

files/image_config/procdockerstats/procdockerstats Outdated Show resolved Hide resolved

pra-moh added 2 commits November 15, 2019 18:38

appending BYTES to converted columns

f049311

changing top 5 to 1024 processes

cd00617

jleveque suggested changes Nov 21, 2019

View reviewed changes

adding d to suggest daemon file

14a1056

jleveque suggested changes Nov 21, 2019

View reviewed changes

files/image_config/procdockerstatsd/procdockerstatsd Outdated Show resolved Hide resolved

removing d from classname

4270c30

hui-ma approved these changes Nov 22, 2019

View reviewed changes

jleveque suggested changes Nov 26, 2019

View reviewed changes

files/build_templates/sonic_debian_extension.j2 Outdated Show resolved Hide resolved

jleveque suggested changes Nov 26, 2019

View reviewed changes

files/image_config/procdockerstatsd/procdockerstatsd.service Outdated Show resolved Hide resolved

adding database.service as dependency

eedab12

adding process/docker in comment

jleveque approved these changes Nov 27, 2019

View reviewed changes

jleveque changed the title ~~adding daemon getting process data~~ Add daemon which periodically pushes process and docker stats to State DB Nov 27, 2019

jleveque merged commit bfa96bb into sonic-net:master Nov 27, 2019

zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020

Add daemon which periodically pushes process and docker stats to Stat…

57e3fd1

…e DB (sonic-net#3525)

prabhataravind mentioned this pull request Apr 19, 2025

Update swss and sairedis modules together to break dependency on each other #22019

Merged

11 tasks

Conversation

pra-moh commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hui-ma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hui-ma commented Oct 25, 2019

Uh oh!

jleveque commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hui-ma commented Oct 25, 2019

Uh oh!

jleveque commented Oct 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jleveque left a comment

Choose a reason for hiding this comment

Uh oh!

pra-moh commented Nov 21, 2019

Uh oh!

Uh oh!

jleveque commented Nov 25, 2019

Uh oh!

Uh oh!

Uh oh!

jleveque commented Nov 27, 2019

Uh oh!

jleveque commented Nov 27, 2019

Uh oh!

pra-moh commented Sep 26, 2019 •

edited

Loading

jleveque commented Oct 25, 2019 •

edited

Loading