[cron.d] Add cron job to periodically clean-up core files#3449
[cron.d] Add cron job to periodically clean-up core files#3449yxieca merged 4 commits intosonic-net:masterfrom
Conversation
* Create script to scan /var/core and clean-up older core files * Create cron job to run clean-up script Signed-off-by: Danny Allen <[email protected]>
| core_files = [f for f in os.listdir(CORE_FILE_DIR) if os.path.isfile(os.path.join(CORE_FILE_DIR, f))] | ||
|
|
||
| core_files_by_process = defaultdict(list) | ||
| for f in core_files: |
There was a problem hiding this comment.
Just a thought, should we have this as a generic infra so this can be used for cleanup other files also (old syslogs, swss.recs etc)?
There was a problem hiding this comment.
That's a good idea! I'll take a look at it.
There was a problem hiding this comment.
This is a great idea. Can we come back with another PR for that?
There are some specialty with core file handling, there are some persisted knowledge of core file name structure here. It is a bit hard to directly apply to log files.
But in general, I think we should have a more generic tool for other files.
There was a problem hiding this comment.
I agree, I think we should put some more thought into a more generic way of doing this. One possible idea is to provide different functions to process different types of files, but let's come back it later.
* [cron.d] Create cron job to periodically clean-up core files * Create script to scan /var/core and clean-up older core files * Create cron job to run clean-up script Signed-off-by: Danny Allen <[email protected]> * Update interval for running cron job * Respond to feedback * Change syslog id
[cron.d] Add cron job to periodically clean-up core files
Signed-off-by: Danny Allen ([email protected])
- What I did
I added a script to periodically clean-up old core files from the /var/core directory and installed it as a cron job in the image. The script is currently configured to keep the 4 newest core files per process in /var/core.
- How to verify it
- Description for the changelog
Add cron job to periodically clean-up core files
- A picture of a cute animal (not mandatory but encouraged)
