Add default dhcp_relay.yml file to OneImage build#341
Closed
jleveque wants to merge 1 commit intosonic-net:masterfrom
jleveque:dhcp_relay_fix
Closed
Add default dhcp_relay.yml file to OneImage build#341jleveque wants to merge 1 commit intosonic-net:masterfrom jleveque:dhcp_relay_fix
jleveque wants to merge 1 commit intosonic-net:masterfrom
jleveque:dhcp_relay_fix
Conversation
lguohan
approved these changes
Feb 27, 2017
taoyl-ms
reviewed
Feb 27, 2017
| # Copy SNMP configuration files | ||
| sudo cp $IMAGE_CONFIGS/snmp/snmp.yml $FILESYSTEM_ROOT/etc/sonic/ | ||
|
|
||
| # Copy initial DHCP relay configuration file, will be overwritten after docker starts |
Contributor
There was a problem hiding this comment.
No I don't think anyone will overwrite this file. This file is the input of config.sh for dhcp relay docker and the real configuration will be generated according to this file.
Contributor
Author
There was a problem hiding this comment.
So until the DHCP servers are stored in the minigraph, this file must be manually edited to contain the actual DHCP server IPs?
taoyl-ms
reviewed
Feb 27, 2017
| @@ -0,0 +1 @@ | |||
| dhcp_servers: [] | |||
Contributor
There was a problem hiding this comment.
Just to double confirm - have you verified that dhcp relay docker can start correctly with this empty value?
Contributor
|
Just discussed offline with Joe - we have agreed that we should embed this information into minigraph. I'll submit another PR for it. |
Contributor
Author
|
Abandoning this PR in favor of #374. |
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Sep 20, 2018
swss: * 13df5a9 2018-09-19 | [cfgmgr]: Add vrfmgrd (sonic-net#621) (HEAD, origin/master, origin/HEAD) [Marian Pritsak] * 54a7c9a 2018-09-18 | [portsorch]: Remove m_ifindex from Port class (sonic-net#624) [Shuotian Cheng] * e765c12 2018-09-17 | [aclorch]: Remove error message when match not found (sonic-net#618) [stepanblyschak] * 07f4cd8 2018-09-14 | Enable vxlan test (sonic-net#620) [pavel-shirshov] * 9fda944 2018-09-14 | Warm reboot: Add support for orchagent pre-shutdown warm-restart state check (sonic-net#562) [Jipan Yang] * 41e61bd 2018-09-14 | Warm reboot: port state sync up (sonic-net#557) [Jipan Yang] * bf38bec 2018-09-14 | [vxlan tunnel]: Don't create encap mapper. Currently not supported (sonic-net#613) [pavel-shirshov] * 528295d 2018-09-14 | [mirrororch]: Remove the queue initialization for different platforms (sonic-net#614) [Shuotian Cheng] * 5af88ab 2018-09-14 | Temporarily disable two test cases to unblock others (sonic-net#617) [Qi Luo] * 60a9d61 2018-09-08 | Support warm-restart for neighsyncd (sonic-net#599) [zhenggen-xu] * 387eac6 2018-09-08 | [mirrororch]: Change Mellanox GRE type to 0x8949 (sonic-net#610) [Shuotian Cheng] * 7114352 2018-09-07 | Store mirror session state in StateDB (sonic-net#609) [Qi Luo] * fa2b5d9 2018-09-06 | [test]: Mark VLAN related mirror test invalid in Debian Jessie (sonic-net#608) [Shuotian Cheng] * 6d40d85 2018-09-06 | [mirrororch]: Fix bug: return false when SAI API call fails (sonic-net#607) [Shuotian Cheng] * cbc5a05 2018-09-05 | [mirrororch]: Enable mirror session destination to point into VLAN (sonic-net#595) [Shuotian Cheng] swss-common: * c6c9a9b 2018-09-19 | Add new macro STATE_FDB_TABLE_NAME (sonic-net#233) (HEAD, origin/master, origin/HEAD) [Qi Luo] * 41b6e18 2018-09-13 | NotificationProducer.send() returns the number of clients that received the message (sonic-net#231) [Qi Luo] sairedis: * 5ef97ca 2018-09-11 | Fix findBridgeVlanForPortVlan for 1Q bridge (sonic-net#345) (HEAD) [Qi Luo] * e402ff6 2018-09-11 | update SAI header (sonic-net#344) [lguohan] * fd75e54 2018-09-11 | sairedis: add while loop to make syncd processEvent() handle as many entries as possible in one event call (sonic-net#335) [Dong Zhang] * 50e1915 2018-08-29 | [misc]: Fix typos (sonic-net#342) [Shuotian Cheng] * 2322375 2018-08-29 | Use syncd -u option (sonic-net#341) [Qi Luo] * 2c2a13c 2018-08-28 | Cleanup usage (sonic-net#340) [Qi Luo] * 7cd75c0 2018-08-26 | [saimeta]: Fix typo: > then -> >; don't exists -> doesn't exist (sonic-net#339) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan
added a commit
that referenced
this pull request
Sep 21, 2018
swss: * 13df5a9 2018-09-19 | [cfgmgr]: Add vrfmgrd (#621) (HEAD, origin/master, origin/HEAD) [Marian Pritsak] * 54a7c9a 2018-09-18 | [portsorch]: Remove m_ifindex from Port class (#624) [Shuotian Cheng] * e765c12 2018-09-17 | [aclorch]: Remove error message when match not found (#618) [stepanblyschak] * 07f4cd8 2018-09-14 | Enable vxlan test (#620) [pavel-shirshov] * 9fda944 2018-09-14 | Warm reboot: Add support for orchagent pre-shutdown warm-restart state check (#562) [Jipan Yang] * 41e61bd 2018-09-14 | Warm reboot: port state sync up (#557) [Jipan Yang] * bf38bec 2018-09-14 | [vxlan tunnel]: Don't create encap mapper. Currently not supported (#613) [pavel-shirshov] * 528295d 2018-09-14 | [mirrororch]: Remove the queue initialization for different platforms (#614) [Shuotian Cheng] * 5af88ab 2018-09-14 | Temporarily disable two test cases to unblock others (#617) [Qi Luo] * 60a9d61 2018-09-08 | Support warm-restart for neighsyncd (#599) [zhenggen-xu] * 387eac6 2018-09-08 | [mirrororch]: Change Mellanox GRE type to 0x8949 (#610) [Shuotian Cheng] * 7114352 2018-09-07 | Store mirror session state in StateDB (#609) [Qi Luo] * fa2b5d9 2018-09-06 | [test]: Mark VLAN related mirror test invalid in Debian Jessie (#608) [Shuotian Cheng] * 6d40d85 2018-09-06 | [mirrororch]: Fix bug: return false when SAI API call fails (#607) [Shuotian Cheng] * cbc5a05 2018-09-05 | [mirrororch]: Enable mirror session destination to point into VLAN (#595) [Shuotian Cheng] swss-common: * c6c9a9b 2018-09-19 | Add new macro STATE_FDB_TABLE_NAME (#233) (HEAD, origin/master, origin/HEAD) [Qi Luo] * 41b6e18 2018-09-13 | NotificationProducer.send() returns the number of clients that received the message (#231) [Qi Luo] sairedis: * 5ef97ca 2018-09-11 | Fix findBridgeVlanForPortVlan for 1Q bridge (#345) (HEAD) [Qi Luo] * e402ff6 2018-09-11 | update SAI header (#344) [lguohan] * fd75e54 2018-09-11 | sairedis: add while loop to make syncd processEvent() handle as many entries as possible in one event call (#335) [Dong Zhang] * 50e1915 2018-08-29 | [misc]: Fix typos (#342) [Shuotian Cheng] * 2322375 2018-08-29 | Use syncd -u option (#341) [Qi Luo] * 2c2a13c 2018-08-28 | Cleanup usage (#340) [Qi Luo] * 7cd75c0 2018-08-26 | [saimeta]: Fix typo: > then -> >; don't exists -> doesn't exist (#339) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
…to print error messages to user; Other minor tweaks (sonic-net#341) - Replace calls to 'click.Abort()' with the Click context method 'fail()' which takes an error message as a parameter in order to ensure descriptive messages are printed rather than simply the message, "Aborted" - Change entrypoint name from 'cli' to 'config' - Rename a couple helper functions for clarity - Replace 'print' calls with 'click.echo()' for consistency - Enhance comments
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
In case if user does not pass restoration time, it is assumed that queue will be mitigated indefinitely in an event of PFC storm until user disables watchdog on that port. Signed-off-by: marian-pritsak <marianp@mellanox.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
8 tasks
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jan 23, 2023
platform-daemon: * 88f4b89 2023-01-20 | add data for telemtery enhancement for 'active-active' cable type (sonic-net#332) (HEAD -> 202205) [vdahiya12] platform-common: * ee986fe 2023-01-21 | add SOP ROC in bulk status (sonic-net#341) (HEAD -> 202205) [qinchuanares] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Jan 23, 2023
…3487) platform-daemon: * 88f4b89 2023-01-20 | add data for telemtery enhancement for 'active-active' cable type (#332) (HEAD -> 202205) [vdahiya12] platform-common: * ee986fe 2023-01-21 | add SOP ROC in bulk status (#341) (HEAD -> 202205) [qinchuanares] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 24, 2023
d0e1ccf - [syseeprom] Remove the trailing space in the value of VENDOR_EXT field in the eepromTlvInfo decode (Add Ingrasys S9100 platform submodule #333) (8 minutes ago) b662bf1 - add SOP ROC in bulk status (Add default dhcp_relay.yml file to OneImage build #341) (17 minutes ago) cdc887c - Don't read AUX_MON_TYPE if memory model is flat ([kernel]: update linux kernel to support z9100 #339) (17 minutes ago) 2236776 - Fix TODO comment ([boardcom]: update saibcm to 2.1.3.1-3 #336) (18 minutes ago) 56397d2 - Removing null characters while decoding from syseeprom ([Makefile]: Automatically rebuild sonic-slave #338) (18 minutes ago) 4651bb0 - [Ci] Upgrade to bullseye and fix the branch reference issue ([platform]: add z9100 platform modules #331) (18 minutes ago) caed733 - Add get_transceiver_status and get_transceiver_pm to API interface (configurations are re-generated across reboots #315) (19 minutes ago) 75d7664 - Use github code scanning instead of LGTM ([platform]: add port_config.ini for dell z9100 #328) (4 weeks ago) 94595a8 - Add warning/critical thresholds for PSU power (Combine alias_map.json with port_config.ini #304) (6 weeks ago)
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Mar 7, 2023
linkmgrd: * 046bdd0 2023-03-06 | [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (HEAD -> 202205) [Jing Zhang] * 15ba715 2023-03-06 | loose link down swithcover condition (sonic-net#178) [Jing Zhang] utilities: * 51d9c9f6 2023-03-06 | [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown (sonic-net#2714) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 03aa77b3 2023-03-02 | [ci] Fix pipeline issue caused by sonic-slave-* change. (sonic-net#2709) [Liu Shilong] * 4bd7d4f1 2023-03-03 | [db_migrator] Add missing attribute 'weight' to route entries in APPL DB (sonic-net#2691) [Vaibhav Hemant Dixit] * 69a60397 2023-03-01 | removed duplicates and resolved conflicts (sonic-net#2674) (github/202205) [kannankvs] platform-daemon: * 10bc119 2023-03-06 | [ycable] add changes for correcting telemetry values for 'active-active' (sonic-net#341) (HEAD -> 202205) [vdahiya12] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
8 tasks
StormLiangMS
added a commit
that referenced
this pull request
Mar 7, 2023
Why I did it 6391de0 - [ycable] add changes for correcting telemetry values for 'active-active' (Add default dhcp_relay.yml file to OneImage build #341) (4 hours ago) [vdahiya12] 2cb31c4 - Update CMIS module types for 2x100G AOC support ([kernel]: update linux kernel to support z9100 #339) (4 hours ago) [mihirpat1] 2ea9cf2 - [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs ([Makefile]: Automatically rebuild sonic-slave #338) (4 hours ago) [vdahiya12] How I did it How to verify it
yxieca
added a commit
that referenced
this pull request
Mar 8, 2023
…#14120) linkmgrd: * 046bdd0 2023-03-06 | [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (#179) (HEAD -> 202205) [Jing Zhang] * 15ba715 2023-03-06 | loose link down swithcover condition (#178) [Jing Zhang] utilities: * 51d9c9f6 2023-03-06 | [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown (#2714) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 03aa77b3 2023-03-02 | [ci] Fix pipeline issue caused by sonic-slave-* change. (#2709) [Liu Shilong] * 4bd7d4f1 2023-03-03 | [db_migrator] Add missing attribute 'weight' to route entries in APPL DB (#2691) [Vaibhav Hemant Dixit] * 69a60397 2023-03-01 | removed duplicates and resolved conflicts (#2674) (github/202205) [kannankvs] platform-daemon: * 10bc119 2023-03-06 | [ycable] add changes for correcting telemetry values for 'active-active' (#341) (HEAD -> 202205) [vdahiya12] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-platform-daemons submodule pointer to include the following: * 03374b2 [ycable] add changes for correcting telemetry values for 'active-active' ([sonic-net#341](sonic-net/sonic-platform-daemons#341)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
snider-nokia
pushed a commit
to snider-nokia/sonic-buildimage
that referenced
this pull request
Apr 6, 2023
* add SOP ROC in bulk status * add test item
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
Wait till CHASIS_APP_DB PING is successful, host_name and asic_name …
mssonicbld
added a commit
that referenced
this pull request
Feb 11, 2025
…lly (#21699) #### Why I did it src/sonic-gnmi ``` * 1425d56 - (HEAD -> master, origin/master, origin/HEAD) Update incremental config to support multi-asic (#355) (64 minutes ago) [ganglv] * 22f767f - Merge pull request #341 from SuvarnaMeenakshi/fabric_masic (6 hours ago) [SuvarnaMeenakshi] * d3261f6 - Fix as per review comment (3 days ago) [Suvarna Meenakshi] * d7b74a5 - Modify to use environment variable to specify unit test env (6 days ago) [Suvarna Meenakshi] * 812b1d0 - Use global variable UnitTest as a flag to reinit fabric counters if invoked during unit testing (6 days ago) [Suvarna Meenakshi] * c4fe5c4 - Merge remote-tracking branch 'origin/master' into HEAD (11 days ago) [Suvarna Meenakshi] * bad1f4a - Remove clean up added for debug (11 days ago) [Suvarna Meenakshi] * 5d7586d - Fix incorrect char and space (11 days ago) [Suvarna Meenakshi] * 697005d - Fix white space (11 days ago) [Suvarna Meenakshi] * c2fae6d - Revert "Fix whitespace" (11 days ago) [Suvarna Meenakshi] * 29ffb43 - Fix whitespace (11 days ago) [Suvarna Meenakshi] * 8440cdb - Fix comment (11 days ago) [Suvarna Meenakshi] * e12240c - Add comment (11 days ago) [Suvarna Meenakshi] * 5820035 - Update to reset countersFabricPortNameMap (11 days ago) [Suvarna Meenakshi] * 4c38c8d - Remove empty line (11 days ago) [Suvarna Meenakshi] * c3fa03d - Remove debug prints (11 days ago) [Suvarna Meenakshi] * 583707b - Fix white space add comment as per review comment (12 days ago) [Suvarna Meenakshi] * 4555836 - Fix whitespace (12 days ago) [Suvarna Meenakshi] * 728c3d9 - Add unit test (12 days ago) [Suvarna Meenakshi] * 3246434 - Revert "Add unit-test" (12 days ago) [Suvarna Meenakshi] * e90e6cd - Add unit-test (12 days ago) [Suvarna Meenakshi] * 65187b8 - Modify to work for single asic linecard (3 weeks ago) [Suvarna Meenakshi] * 76314e3 - Merge remote-tracking branch 'origin/master' into fabric_masic (3 weeks ago) [Suvarna Meenakshi] * 316a491 - Modify Fabric port name to append asic namespace to form unique port name within a linecard module (3 weeks ago) [Suvarna Meenakshi] * 8ff0269 - Add multi-asic support for Fabric port counters (4 weeks ago) [Suvarna Meenakshi] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Mar 5, 2025
…atically (#21913) #### Why I did it src/sonic-snmpagent ``` * 25f9e4f - (HEAD -> master, origin/master, origin/HEAD) Handle error seen when interface counter is not available in COUNTERS_DB (#341) (25 hours ago) [SuvarnaMeenakshi] ``` #### How I did it #### How to verify it #### Description for the changelog
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-buildimage
that referenced
this pull request
Aug 1, 2025
…ve' (sonic-net#341) * [ycable] add changes for correcting telemetry values for 'active-active' This change creates unknown, N/A values for active-standby cable types for active-active type cable. Since streaming telemetry today looks for both active-active and active-standby for posting values to State DB, this change introduces a one time posting of fields with 'pseudo-cable' type when channels are attempted to be created by ycabled. Description Motivation and Context How Has This Been Tested? UT and posting the changes on test device. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #330.