DellEMC Z9100 : Platform2.0 API implementation [PSU, Thermal]#3361
Merged
sujinmkang merged 4 commits intosonic-net:masterfrom Sep 18, 2019
ArunSaravananBalachandran:platform2.0_z9100
Merged
DellEMC Z9100 : Platform2.0 API implementation [PSU, Thermal]#3361sujinmkang merged 4 commits intosonic-net:masterfrom ArunSaravananBalachandran:platform2.0_z9100
sujinmkang merged 4 commits intosonic-net:masterfrom
ArunSaravananBalachandran:platform2.0_z9100
Conversation
Collaborator
|
retest mellanox please |
Collaborator
|
@ArunSaravananBalachandran can you please rebase to the latest? |
Contributor
Author
Merge conflicts have been resolved. |
Collaborator
|
retest vsimage please! |
sujinmkang
approved these changes
Sep 18, 2019
Collaborator
sujinmkang
left a comment
sujinmkang
left a comment
There was a problem hiding this comment.
The code looks good to me and I verified the thermal and psu api implementation using the build and the script in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
Wrote python script to load Chassis class and then call get_system_eeprom_info, PSU and Thermal APIs accordingly.
UT Logs : UT_logs-PSU.txt, UT_logs-thermal.txt, UT_logs-eeprom.txt
- Description for the changelog
DellEMC Z9100 : Platform2.0 API implementation [PSU, Thermal]
- A picture of a cute animal (not mandatory but encouraged)