[service dependent] describe non-warm-reboot dependency outside systemd#3311
Merged
yxieca merged 4 commits intosonic-net:masterfrom Aug 8, 2019
Merged
[service dependent] describe non-warm-reboot dependency outside systemd#3311yxieca merged 4 commits intosonic-net:masterfrom
yxieca merged 4 commits intosonic-net:masterfrom
Conversation
…mctl When dependency was described with systemctl, it will kick in all the time, including under warm reboot/restart scenarios. This is not what we always want. For components that are capable of warm reboot/start, they need to describe dependency in service files. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Collaborator
|
i think the reason is that in the warm reboot mode, we need to first stop swss and then do the SAI pre-shutdown, finally, we stop the team service to give us full 90 seconds for coming up. |
lguohan
reviewed
Aug 8, 2019
lguohan
reviewed
Aug 8, 2019
lguohan
approved these changes
Aug 8, 2019
Adding require swss will cause teamd to be killed by systemctl when swss stops. This is not what we want in warm reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
suggested changes
Aug 8, 2019
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
As comments, plus please also fix typo in PR title ("systenctk").
Suggest to change the title to: "[services] Describe non-warm-reboot dependency outside systemd"
yxieca
changed the title
yxieca
changed the title
jleveque
approved these changes
Aug 8, 2019
yxieca
changed the title
yxieca
added a commit
that referenced
this pull request
Aug 8, 2019
…md (#3311) * [service dependent] describe non-warm-reboot dependency outside systemctl When dependency was described with systemctl, it will kick in all the time, including under warm reboot/restart scenarios. This is not what we always want. For components that are capable of warm reboot/start, they need to describe dependency in service files. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [service] teamd service should not require swss service Adding require swss will cause teamd to be killed by systemctl when swss stops. This is not what we want in warm reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * refactoring code * rename functions to match other functions in the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When dependency was described with systemctl, it will kick in all the time,
including under warm reboot/restart scenarios. This is not what we always
want. For components that are capable of warm reboot/start, they need to
describe dependency in service files.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Without this change, when warm reboot test is executed, randomly the LAGs would flap. When running continuous warm reboot test, the LAG up time on the peers will eventually show this problem.
With the change in place, the LAG reset is not seen.