[as5835-54x] Implement get_transceiver_change_event() in sfputil.py#3308
Merged
jleveque merged 2 commits intosonic-net:masterfrom Aug 13, 2019
Merged
[as5835-54x] Implement get_transceiver_change_event() in sfputil.py#3308jleveque merged 2 commits intosonic-net:masterfrom
jleveque merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: brandon_chuang <brandon_chuang@CicadaBuildServer.accton.com.tw>
lguohan
reviewed
Aug 8, 2019
| return int(rev,16) | ||
|
|
||
| data = {'valid':0, 'last':0, 'present':0} | ||
| def get_transceiver_change_event(self, timeout=2000): |
Collaborator
There was a problem hiding this comment.
this function is a blocking call and the default timeout is 0 meaning it is blocking.
lguohan
requested changes
Aug 8, 2019
Collaborator
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
implementation does not meet the spec.
…he spec Signed-off-by: brandon_chuang <brandon_chuang@CicadaBuildServer.accton.com.tw>
Contributor
Author
|
Add another commit to follow the spec. |
lguohan
approved these changes
Aug 13, 2019
Collaborator
|
retest vsimage please |
jleveque
approved these changes
Aug 13, 2019
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
…onic-net#3308) Signed-off-by: brandon_chuang <brandon_chuang@CicadaBuildServer.accton.com.tw>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: brandon_chuang brandon_chuang@edge-core.com
- What I did
- How I did it
Read the presence status of all ports from CPLD and update the presence dictionary in get_transceiver_change_event() of sfputil.py
- How to verify it
sfputil show presence
sfputil show eeprom
show interfaces transciever