-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[build]: add the support of Apt-Cacher-NG proxy configuration to the … #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
ef5064f
229ef40
53f8934
32686cc
4658546
67474f7
12f0256
1052e78
9ad54b8
03ec08b
e78b7af
e8ae509
f7ca312
46a480b
51af28d
9348a3c
6c64b1f
d7096e8
635ddce
0d84105
24e65cc
bd3a8bf
af5c544
01786b2
448d40a
97467e3
fbf6165
d3ce652
70c75c4
e53101b
5d376a6
125b394
f7f5d6e
52f31b3
3ed7cb7
ccbc3ec
ae79f67
d63d306
ba4566f
dedd2cc
89bc93e
aaf76b3
8e95699
98fdea9
8f27851
ccd51c2
ce07586
5196f13
7b53d43
b99981b
52ef900
65a179e
f739f1c
2cef1ef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,10 @@ RUN rm -rf \ | |
| /var/cache/man/* \ | ||
| /usr/share/locale/* | ||
|
|
||
| {% if APT_CACHER_NG_PROXY.strip() -%} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggest rename to APT_PROXY, Apt-Cacher-NG is a specific apt proxy implementation. |
||
| RUN echo 'Acquire::http::Proxy "{{APT_CACHER_NG_PROXY}}";' >> /etc/apt/apt.conf.d/02proxy | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Does it impact runtime proxy? If yes, production switches may have no access to build environment at all.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggest remove the leading spaces. |
||
| {%- endif %} | ||
|
|
||
| # Make apt-get non-interactive | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is not same as above lines