Conversation
|
minigraph.xml is not needed. |
Will remove |
|
can you resolve the conflict? |
done |
yxieca
added
Included in 201811 Branch
Request for 201811 Branch 
and removed
Included in 201811 Branch
labels
There was a problem hiding this comment.
index match the front panel port number.
There was a problem hiding this comment.
can you elaborate?
There was a problem hiding this comment.
https://github.com/Azure/SONiC/wiki/Porting-Guide
section port_config.ini
There was a problem hiding this comment.
I went over the doc. Do you mean index should start from 1 instead of 0?
There was a problem hiding this comment.
@lguohan - does having Index start at 1 instead of 0 have impact on the platform? We wanted to keep behavior same by matching indexing as if index column wasn't there (default starting at 0)
There was a problem hiding this comment.
this column is used for show user which front panel port number it is. therefore it should match front panel port number. if your box front panel port index starts from 0 then you should use 0. if your box front panel port index start from 1, then you should use 1.
There was a problem hiding this comment.
The show interface transceiver eeprom/presence commands are adversely impacted if we switch to 1 base. There seems to be a degree of hardcoding to start at 0 on both ODM and SONiC side. For most folks we worked with, they use Alias column to show front panel mapping / breakout.
There was a problem hiding this comment.
which part is hardcoded? you can check other platform is using index starting from 1.
|
can you resolve conflict? |
[build] Add ipmitool [dockers] Add innovium platform in orchagent + ipmitool in snmp [platform/innovium] Add innovium platform [device/celestica] Add x86_64-cel_midstone-r0 device for innovium [device/delta] Add x86_64-delta_et-c032if-r0 device for innovium [sonic-slave-stretch] Add texi2html Signed-off-by: Tony Titus [email protected]
Done |
|
Unable to cherry-pick to 201811 branch cleanly directly. An new PR is needed. |
[build] Add ipmitool [dockers] Add innovium platform in orchagent + ipmitool in snmp [platform/innovium] Add innovium platform [device/celestica] Add x86_64-cel_midstone-r0 device for innovium [device/delta] Add x86_64-delta_et-c032if-r0 device for innovium [sonic-slave-stretch] Add texi2html Signed-off-by: Tony Titus [email protected]
[build] Add ipmitool [dockers] Add innovium platform in orchagent + ipmitool in snmp [platform/innovium] Add innovium platform [device/celestica] Add x86_64-cel_midstone-r0 device for innovium [device/delta] Add x86_64-delta_et-c032if-r0 device for innovium [sonic-slave-stretch] Add texi2html Signed-off-by: Tony Titus [email protected]
[build] Add ipmitool [dockers] Add innovium platform in orchagent + ipmitool in snmp [platform/innovium] Add innovium platform [device/celestica] Add x86_64-cel_midstone-r0 device for innovium [device/delta] Add x86_64-delta_et-c032if-r0 device for innovium [sonic-slave-stretch] Add texi2html Signed-off-by: Tony Titus [email protected]
5 participants
[build] Add ipmitool
[dockers] Add innovium platform in orchagent + ipmitool in snmp
[platform/innovium] Add innovium platform
[device/celestica] Add x86_64-cel_midstone-r0 device for innovium
[device/delta] Add x86_64-delta_et-c032if-r0 device for innovium
[sonic-slave-stretch] Add texi2html
Signed-off-by: Tony Titus [email protected]
- What I did
Added Innovium platform support
- How I did it
- How to verify it
Ran PTF tests for T0, T1 and PTF32 topologies
- Description for the changelog
Add support for Innovium platform with corresponding devices.
- A picture of a cute animal (not mandatory but encouraged)