[Mellanox] Fix the memory leak in mlnx-sfpd#3128
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Jul 9, 2019
stephenxs:fix-mlnx-sfpd-leak
Merged
[Mellanox] Fix the memory leak in mlnx-sfpd#3128liat-grozovik merged 2 commits intosonic-net:masterfrom stephenxs:fix-mlnx-sfpd-leak
liat-grozovik merged 2 commits intosonic-net:masterfrom
stephenxs:fix-mlnx-sfpd-leak
Conversation
…vention new_<type_name> should be release explicitly via delete_<type_name>.
keboliu
approved these changes
Jul 8, 2019
lguohan
approved these changes
Jul 8, 2019
Collaborator
|
@jleveque , we should do pmon memory limit so that it won't impact other services in sonic. |
Collaborator
|
can you identify which branch are affected? |
jleveque
approved these changes
Jul 8, 2019
Collaborator
|
Collaborator
Author
PR#3131 for 201807 |
yxieca
pushed a commit
that referenced
this pull request
Jul 10, 2019
* fix the memory leak in on_pmpe. objects created via sx_api having convention new_<type_name> should be release explicitly via delete_<type_name>. * avoid duplicate code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the memory leak in mlnx-sfpd.
- How I did it
Fix the memory leak in mlnx-sfpd::on_pmpe.
- How to verify it
reset an SFP module, and then:
- Description for the changelog
[Mellanox] Fix the memory leak in mlnx-sfpd
- A picture of a cute animal (not mandatory but encouraged)