[Mellanox] fix the issue that failing to test whether dom supported prior to reading dom data#3120
Merged
lguohan merged 3 commits intosonic-net:masterfrom Jul 6, 2019
stephenxs:fix-dom-capability-detect
Merged
[Mellanox] fix the issue that failing to test whether dom supported prior to reading dom data#3120lguohan merged 3 commits intosonic-net:masterfrom stephenxs:fix-dom-capability-detect
lguohan merged 3 commits intosonic-net:masterfrom
stephenxs:fix-dom-capability-detect
Conversation
… dom supported prior to reading dom data
stephenxs
changed the title
no need to read 16 bytes, 1 byte is enough since calibration and dom capability are all in bytes at offset 92
nazariig
reviewed
Jul 5, 2019
nazariig
reviewed
Jul 5, 2019
nazariig
approved these changes
Jul 5, 2019
Collaborator
|
retest this please |
lguohan
approved these changes
Jul 6, 2019
mssonicbld
added a commit
that referenced
this pull request
Feb 6, 2024
…atically (#18049) #### Why I did it src/sonic-utilities ``` * b548735 - (HEAD -> master, origin/master, origin/HEAD) [route_check.py] account static routes in route_check.py (#3120) (9 hours ago) [Stepan Blyshchak] * 64e1f9f - [Mellanox buffer migrator] Do not touch the buffer model on generic SKUs if the buffer configuration is empty (#3114) (19 hours ago) [Stephen Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
fix the issue that failing to test whether dom supported prior to reading dom data.
it depends on pr https://github.com/Azure/sonic-buildimage/pull/3118)
- How I did it
test dom support prior to reading dom data for SFP.
- How to verify it
check whether log "Cannot get Module EEPROM data: Invalid argument" can be found in syslog in a testbed that has some SFP modules without DOM supporting.
- Description for the changelog
fix the issue that failing to test whether dom supported prior to reading dom data
- A picture of a cute animal (not mandatory but encouraged)