[sairedis.mk] do not build rpc sairedis when not needed#3109
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jul 6, 2019
Merged
[sairedis.mk] do not build rpc sairedis when not needed#3109lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
force-pushed
the
dont_build_rpc_if_not_needed
branch
from
62f66ed to
250421b
Compare
lguohan
reviewed
Jul 2, 2019
| # Inject brcm sai into sairedis | ||
| $(LIBSAIREDIS)_DEPENDS += $(BRCM_SAI) $(BRCM_SAI_DEV) $(LIBSAITHRIFT_DEV) | ||
| $(LIBSAIREDIS)_DEPENDS += $(BRCM_SAI) $(BRCM_SAI_DEV) | ||
| ifeq ($(ENABLE_SYNCD_RPC),y) |
Collaborator
There was a problem hiding this comment.
sai server also need libsaithrift
Collaborator
Author
There was a problem hiding this comment.
@lguohan
saiserver is a different target which has dependency on libsaithrift, so if you build docker-saiserver it will build libthrift and libsaithrift if ENABLE_SYNCD_RPC is off
Double checked by running:
make -f slave.mk target/docker-saiserver-mlnx.gz
lguohan
approved these changes
Jul 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)