DELL Platform 2.0 API Infra and Reboot Reason support in Z9100 & S6100#3063
Merged
lguohan merged 10 commits intosonic-net:masterfrom Jul 3, 2019
Merged
DELL Platform 2.0 API Infra and Reboot Reason support in Z9100 & S6100#3063lguohan merged 10 commits intosonic-net:masterfrom
lguohan merged 10 commits intosonic-net:masterfrom
Conversation
Contributor
Author
jleveque
suggested changes
Jun 21, 2019
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Thanks for this PR! Please see my review comments.
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @jleveque Thanks for the review comments. Will address it and upload soon. Thanks |
Contributor
Author
jleveque
reviewed
Jun 24, 2019
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
Contributor
Author
jleveque
reviewed
Jun 28, 2019
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
jleveque
suggested changes
Jul 1, 2019
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
jleveque
suggested changes
Jul 2, 2019
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
jleveque
approved these changes
Jul 2, 2019
Contributor
|
Please resolve conflicts. |
Contributor
Author
|
Hi @jleveque |
Contributor
Author
|
Hi @jleveque I have resolved the conflicts. Request you to merge the changes Thanks |
Contributor
|
@sridhar-ravindran: I will merge once all check builds pass. |
Contributor
|
Retest vs please |
Contributor
|
This commit cannot be cherry-picked cleanly into 201811 branch. |
Contributor
Author
Hi Ying, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added platform 2.0 API support infra for Dell platform s6100 & z9100
- How I did it
https://github.com/Azure/SONiC/blob/540d890d3acbc9e424dac75f0f671cbb352f0a52/doc/platform_api/new_platform_api.md
Adhered to the latest solution proposed.
This code has dependancy on
#3059
- How to verify it
Added a stub code in show/main.py and verified show reboot-cause command.
UT logs attached with more details.
- Description for the changelog
DELLEMC : S6100,Z9100 Platform 2.0 API Infra Support
- A picture of a cute animal (not mandatory but encouraged)