[Mellanox]Remove the dependency on sysfs for sfputil#2967
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jun 7, 2019
stephenxs:remove-sfp-sysfs
Merged
[Mellanox]Remove the dependency on sysfs for sfputil#2967lguohan merged 2 commits intosonic-net:masterfrom stephenxs:remove-sfp-sysfs
lguohan merged 2 commits intosonic-net:masterfrom
stephenxs:remove-sfp-sysfs
Conversation
added 2 commits
June 4, 2019 08:28
…nce and port_to_eeprom_mapping Remove the dependency on sysfs, including: 1. rewrite get_presence by using ethtool; 2. remove interface port_to_eeprom_mapping which is no longer referenced; 3. remove code that references port_to_eeprom_mapping and _port_to_eeprom_mapping; 4. remove private member qsfp_sysfs_path which is no longer referenced.
minor adjustment: move the presence=False to the beginning of get_presence.
keboliu
approved these changes
Jun 6, 2019
lguohan
approved these changes
Jun 7, 2019
mssonicbld
added a commit
that referenced
this pull request
Dec 14, 2023
…lly (#17501) #### Why I did it src/sonic-swss ``` * ff524e6 - (HEAD -> master, origin/master, origin/HEAD) [dash] add a retry for an ACL rule creation if a tag is not created yet (#2972) (7 hours ago) [Yakiv Huryk] * 620db3d - [ci] Allow partially success build artifact in PR checker pipeline. #2986 (3 days ago) [Liu Shilong] * d357e6f - [copporch] Add safeguard during policer attribute update (#2977) (4 days ago) [Vivek] * cb46039 - [fpmsyncd][WR] Relax the static schema constraint for ROUTE_TABLE (#2981) (5 days ago) [Vivek] * a1ce21f - Change base directory referenced in coverage.xml (#2976) (6 days ago) [Lawrence Lee] * 920959c - [Dash] [UT] Add ZMQ test case for dash (#2967) (6 days ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Remove the dependency on sysfs for sfputil, mainly get_presence and port_to_eeprom_mapping
- How I did it
in sfputil.py:
- How to verify it
sudo sfputil show -p Ethernetxxx
sudo sfputil show -d -p Ethernetxxx
- Description for the changelog
Remove the dependency on sysfs for sfputil
Signed-off-by: Stephen Sun [email protected]