[Mellanox] Expose SDK share buffer and unix socket from syncd#2951
Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom Jun 5, 2019
keboliu:expose-sdk
Merged
[Mellanox] Expose SDK share buffer and unix socket from syncd#2951qiluo-msft merged 3 commits intosonic-net:masterfrom keboliu:expose-sdk
qiluo-msft merged 3 commits intosonic-net:masterfrom
keboliu:expose-sdk
Conversation
nazariig
reviewed
May 28, 2019
nazariig
reviewed
May 28, 2019
qiluo-msft
reviewed
May 29, 2019
qiluo-msft
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Expose SDK share buffer and unix socket from syncd, so other containers can call SDK API with accessing these stuff.
- How I did it
Remove line --tmpfs /tmp \ in Mellanox syncd docker create command
Add line -v sx_api:/tmp \ in docker create command to share /tmp/sx_api unix socket
Add line -v /dev/shm:/dev/shm:rw \ to expose share buffer
- How to verify it
run regression on Mellanox platform
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)