[Mellanox] SFP new platform API implementation#2944
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom May 29, 2019
keboliu:sfp-new-api
Merged
[Mellanox] SFP new platform API implementation#2944liat-grozovik merged 2 commits intosonic-net:masterfrom keboliu:sfp-new-api
liat-grozovik merged 2 commits intosonic-net:masterfrom
keboliu:sfp-new-api
Conversation
lguohan
approved these changes
May 28, 2019
jleveque
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Implement the new SFP API for Mellanox platform.
the Setting APIs not finished yet, design ongoing, will be implemented in phase 2,
some get function for channel disable status, lpmode status and power override status not implemented,
will implement them after the set functions finalized.
This PR has a dependency on #2943, can only be merged after PR 2943
- How I did it
Add new file sfp.py for SFP new API, make use of ethtool.
Add code to chassis.py to initialize SFPs
- How to verify it
need a specific script to call these APIs
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)