[mlnx] refactor and fix mlnx-sfpd shutdown#2907
Merged
lguohan merged 3 commits intosonic-net:masterfrom May 17, 2019
Merged
Conversation
added 2 commits
May 16, 2019 15:30
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
lguohan
approved these changes
May 17, 2019
yxieca
pushed a commit
that referenced
this pull request
May 20, 2019
* [mlnx] fix mlnx-sfpd shutdown Signed-off-by: Stepan Blyschak <[email protected]> * fix type and handle only EINTR and EAGAIN errors from select Signed-off-by: Stepan Blyschak <[email protected]> * handle select.error as well during init/run Signed-off-by: Stepan Blyschak <[email protected]>
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
* [mlnx] fix mlnx-sfpd shutdown Signed-off-by: Stepan Blyschak <[email protected]> * fix type and handle only EINTR and EAGAIN errors from select Signed-off-by: Stepan Blyschak <[email protected]> * handle select.error as well during init/run Signed-off-by: Stepan Blyschak <[email protected]>
qiluo-msft
reviewed
Jul 23, 2019
| SX_TRAP_ID_PMPE, | ||
| self.user_channel_p) | ||
| if rc != SX_STATUS_SUCCESS: | ||
| raise RuntimeError("sx_api_host_ifc_trap_id_register_set exited with error, rc {}".format(c)) |
Collaborator
There was a problem hiding this comment.
c [](start = 102, length = 1)
c is not existing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
- What I did
Fix mlnx-sfpd shutdown flow as it does not handles SIGTERM, SIGINT correctly and supervisord kills mlnx-sfpd with SIGKILL after timeout
- How I did it
Use select, select will raise exception if interrupted with signal
- How to verify it
TODO: test cable plug in/plug out
- Description for the changelog
[mlnx] fix mlnx-sfpd shutdown
- A picture of a cute animal (not mandatory but encouraged)