Add a unit test in sonic-cfggen to test argument "--var-json"#2906
Merged
lguohan merged 1 commit intosonic-net:masterfrom May 19, 2019
Merged
Add a unit test in sonic-cfggen to test argument "--var-json"#2906lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
can you resolve the build issue |
Collaborator
|
retest this please |
lguohan
approved these changes
May 19, 2019
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Adding a unit test in sonic-cfggen to test argument
--var-json- How I did it
Modifying file test_cfggen.py in sonic-cfggen's unit test to test argument
--var-jsonof sonic-cfggen- How to verify it
Executing following commands in sequence and there is no error occurs: