Fix for LLDP portname issue#2886
Merged
sumukhatv merged 2 commits intosonic-net:masterfrom May 10, 2019
sumukhatv:lldp_portname
Merged
Fix for LLDP portname issue#2886sumukhatv merged 2 commits intosonic-net:masterfrom sumukhatv:lldp_portname
sumukhatv merged 2 commits intosonic-net:masterfrom
sumukhatv:lldp_portname
Conversation
First check for operstate and if its not present then check for ifindex
Contributor
pavel-shirshov
left a comment
pavel-shirshov
left a comment
There was a problem hiding this comment.
Can you please review my comments?
pavel-shirshov
approved these changes
May 10, 2019
lguohan
approved these changes
May 10, 2019
yxieca
pushed a commit
that referenced
this pull request
May 14, 2019
* Fix for LLDP portname issue First check for operstate and if its not present then check for ifindex * Addressing review comments
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
* Fix for LLDP portname issue First check for operstate and if its not present then check for ifindex * Addressing review comments
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 11, 2023
sonic-utilities submodule update #### Why I did it sonic-utilities submodule update: ``` 399b1e3 2023-07-06 [202012][Show][BGP] Show BGP Change for no neighbor scenario (#2886) 7b47641 2023-07-10 [[202012] [TACACS+] Add config command for AAA authorization and accounting. (#1889) ``` ##### Work item tracking - Microsoft ADO **(number only)**:24433713 #### How I did it Update sonic-utilities submodule. #### How to verify it Pass all test case. #### Tested branch (Please provide the tested image version) - [ ] SONiC.202012-15703.306864-1ef589c19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First check for operstate and if its not present then check for ifindex
- What I did
Fixed the issue in LLDP where portname was advertised as a MAC address instead
- How I did it
To decide whether a port exists, first we check for operstate file. If this file is present, then we check if the state is "up" or not. If the file itself is not present, then we know that it is a v-switch, so we can now look for ifindex file and make a decision whether the port exists or not.
- How to verify it
- Description for the changelog
To decide the existence of a port, check for status in the operstate file. If this file is not present check ifindex file.
- A picture of a cute animal (not mandatory but encouraged)