Skip to content

Administratively shutdown port channel has member ports in deselected state and traffic is not forwarded. #1771 #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 4 commits into from
May 29, 2019
Merged

Administratively shutdown port channel has member ports in deselected state and traffic is not forwarded. #1771 #2882

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7dcf099
Administratively shutting down port channel will remove the ports fro…
phanindra-tv May 10, 2019
0705258
#2882
phanindra-tv May 17, 2019
0c45e08
#2882
phanindra-tv May 21, 2019
03d2db5
#2882
phanindra-tv May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/libteam/0013-teamd-lacp-port-admin-down-recv-not-processing.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c
index 5fa026a..5f4ba75 100644
--- a/teamd/teamd_runner_lacp.c
+++ b/teamd/teamd_runner_lacp.c
@@ -1179,12 +1179,20 @@ static int lacpdu_recv(struct lacp_port *lacp_port)
struct lacpdu lacpdu;
struct sockaddr_ll ll_from;
int err;
+ bool admin_state;

err = teamd_recvfrom(lacp_port->sock, &lacpdu, sizeof(lacpdu), 0,
(struct sockaddr *) &ll_from, sizeof(ll_from));
if (err <= 0)
return err;

+ admin_state = team_get_ifinfo_admin_state(lacp_port->ctx->ifinfo);
+ if (!admin_state) {
+ teamd_log_dbg("%s received PDU in admin down state.",
+ lacp_port->tdport->ifname);
+ return 0;
+ }
+
return lacpdu_process(lacp_port, &lacpdu);
}

1 change: 1 addition & 0 deletions src/libteam/series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
0010-teamd-lacp-update-port-state-according-to-partners-sy.patch
0011-libteam-resynchronize-ifinfo-after-lost-RTNLGRP_LINK-.patch
0012-teamd-do-not-process-lacpdu-before-the-port-ifinfo-i.patch
0013-teamd-lacp-port-admin-down-recv-not-processing.patch