-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updated Makefile infrastructure to build debug images. #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
941eb7d
Updated Makefile infrastructure to build debug images.
renukamanavalan 042d51e
Dropped the regular binary using DBG_PACKAGES and a small name change…
renukamanavalan 24f38f2
Tweaked the changes to retain the existing behavior w.r.t INSTALL_DEB…
renukamanavalan 4443c70
1) slave.mk - Dropped unused Docker build args
renukamanavalan 7b84e64
Reverted some changes, per review comments.
renukamanavalan c717e50
Merge remote-tracking branch 'upstream/master'
renukamanavalan 60a001c
Get in sync with the new update that filters out dockers to be built …
renukamanavalan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #! /bin/bash | ||
|
|
||
| echo " | ||
| FROM $1 | ||
|
|
||
| ARG docker_container_name | ||
|
|
||
| ## Make apt-get non-interactive | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| {% if $2 is defined %} | ||
| {% if $2|length %} | ||
|
|
||
| COPY \ | ||
| {% for deb in $2.split(' ') -%} | ||
| debs/{{ deb }}{{' '}} | ||
| {%- endfor -%} | ||
| debs/ | ||
|
|
||
| RUN dpkg -i \ | ||
| {% for deb in $2.split(' ') -%} | ||
| debs/{{ deb }}{{' '}} | ||
| {%- endfor %} | ||
|
|
||
| {% endif %} | ||
| {% endif %} | ||
|
|
||
| {% if $3 is defined %} | ||
| {% if $3|length %} | ||
|
|
||
| RUN apt-get install -f -y \ | ||
| {% for dbg in $3.split(' ') -%} | ||
| {{ dbg }}{{' '}} | ||
| {%- endfor %} | ||
|
|
||
| {% endif %} | ||
| {% endif %} | ||
|
|
||
|
|
||
| ## Clean up | ||
| RUN apt-get clean -y; apt-get autoclean -y; apt-get autoremove -y | ||
| RUN rm -rf /debs | ||
|
|
||
| " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are install those debug packages in the DBG docker images, we likely do not need this option now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we would not need. Below is my comments (copy/paste from commit comments):
"
Tweaked the changes to retain the existing behavior w.r.t INSTALL_DEBUG_TOOLS=y.
When this change ('building debug docker image transparently') is extended to all dockers, this flag would become redundant. Yet, there can be some test based use cases that rely on this flag.
Until after all the dockers gets their debug images by default and we switch all use cases of this flag to use the newly built debug images, we need to maintain the existing behavior.
"