Revert "[teamd service] teamd service should start after syncd"#2733
Merged
Revert "[teamd service] teamd service should start after syncd"#2733
Conversation
This reverts commit 0d1efb1.
qiluo-msft
approved these changes
Apr 3, 2019
jipanyang
approved these changes
Apr 3, 2019
Collaborator
jipanyang
left a comment
jipanyang
left a comment
There was a problem hiding this comment.
If there is race condition in teamd that causes lags unable to get ARP packets served, I doubt changing teamd to start only after swss will solve the problem completely.
yxieca
added a commit
that referenced
this pull request
Apr 4, 2019
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…-net#2724)" (sonic-net#2733) This reverts commit 0d1efb1.
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…-net#2724)" (sonic-net#2733) This reverts commit 0d1efb1.
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…-net#2724)" (sonic-net#2733) This reverts commit 0d1efb1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2724
Found an issue with this change in test: this change exposes a race condition in teamd that causes lags unable to get ARP packets served. The result is that even the LAGs are up, we are unable to ping the peer and BGP on top of these LAGs are unable to establish.
I experimented to change teamd start only after swss (to solve the teamd/swss race condition), that seems to be able to avoid the race condition.
The race condition could be platform specific. We need to investigate further before coming back with a proper solution.