sonic-platform-modules-nexthop: Enable ASIC polling by default#26520
Draft
frank-nexthop wants to merge 1 commit intosonic-net:masterfrom
Draft
sonic-platform-modules-nexthop: Enable ASIC polling by default#26520frank-nexthop wants to merge 1 commit intosonic-net:masterfrom
frank-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
* Within asic thermal class, set ASIC polling database values to platform.json defaults on the first polling iteration fixes sonic-net#26516 Signed-off-by: Frank Jiang <[email protected]>
|
|
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azpw ms_conflict |
2 similar comments
Contributor
|
/azpw ms_conflict |
Contributor
|
/azpw ms_conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within the Nexthop asic thermal class, set ASIC polling database values to platform.json defaults on the first polling iteration
fixes #26516
Why I did it
Currently, for Nexthop platforms, ASIC polling is not present in the config by default. This causes all ASIC temperatures to be displayed as 0 when running
show plat temp.Work item tracking
How I did it
When thermalctld is started, when the temperatures are first polled, the Nexthop specific platform code will guarantee that the ASIC polling database values are set to the defaults set in platform.json. For all Nexthop platforms right now, this means that ASIC polling will be enabled by default.
How to verify it
Built a sonic image with this change, and loaded it onto a Nexthop device. Confirmed that on first boot ASIC polling works properly without any manual changes to the configuration/database.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Within the Nexthop asic thermal class, set ASIC thermal polling database values to platform.json defaults on the first polling iteration.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)