Skip to content

ci: fix golang security#26324

Merged
wangxin merged 1 commit intosonic-net:masterfrom
auspham:austinpham/36979761-fix-golang-security-vulnerability
Mar 23, 2026
Merged

ci: fix golang security#26324
wangxin merged 1 commit intosonic-net:masterfrom
auspham:austinpham/36979761-fix-golang-security-vulnerability

Conversation

@auspham
Copy link
Contributor

@auspham auspham commented Mar 23, 2026

Why I did it

Currently there is a golang vulnerability golang.org/x/net (GHSA-qxp5-gwg8-xv66) which flagged since the x/net is 0.33.0 instead of 0.36.0. This could be a transitive module.

To address this, we can build grpcurl from source instead.

Work item tracking
  • Microsoft ADO (number only): 36979761

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@auspham auspham requested a review from lguohan as a code owner March 23, 2026 00:19
Copilot AI review requested due to automatic review settings March 23, 2026 00:19
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the docker-ptf container build to remediate a reported Go module vulnerability by forcing grpcurl to be built from source with a newer golang.org/x/net version, aligning the PTF image with current security scanning expectations.

Changes:

  • Switch grpcurl installation from go install ...@v1.9.3 to a source build from the grpcurl repo tag.
  • Explicitly upgrade/pin golang.org/x/net to v0.36.0 during the grpcurl build to address GHSA-qxp5-gwg8-xv66.

@yijingyan2
Copy link
Contributor

/azpw ms_conflict

@wangxin wangxin merged commit f3ba7ba into sonic-net:master Mar 23, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants