Allow configuration of platform-specific interfaces#2631
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 9, 2019
pyadvichuk:bfn-bmc-intf-configuration
Merged
Allow configuration of platform-specific interfaces#2631lguohan merged 1 commit intosonic-net:masterfrom pyadvichuk:bfn-bmc-intf-configuration
lguohan merged 1 commit intosonic-net:masterfrom
pyadvichuk:bfn-bmc-intf-configuration
Conversation
Contributor
|
@pyadvichuk without auto config in " iface usb0 inet6 auto" is the BMC interface configured correctly. What is the default when auto/dhcp/static is not used. We need the BMC to come with some IPv6 address config |
Collaborator
|
@pyadvichuk , please sign cla. |
Author
@mkbalani, by default static link level v6 address is assigned. I've checked REST over this interface by |
akokhan
approved these changes
Mar 3, 2019
marian-pritsak
previously requested changes
Mar 3, 2019
mkbalani
approved these changes
Mar 4, 2019
Contributor
|
@lguohan is there anything that blocks us from merging this? Thanks. |
lguohan
approved these changes
Mar 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why it is required
since SONiC master switches
ifupdownpackage to the new implementation (ifupdown2), it is required to change the configuration of a platform-specific interface forwedge100bf_32xandwedge100bf_65xplatforms (bc ofifupdown2doesn't supportautomode forinet6protocol).Also, need to make some refactoring and remove
if platform == smth then..from the system level scripts.- What I did
/usr/bin/interfaces-config.sh/etc/network/interfaces.d/etc/network/interfacesgeneration template (to include platform-specific interfaces processing)wedge100bf_32xandwedge100bf_65x)sonic-config-engine- How to verify it
sudo config reload -yon new installationusb0interface- Description for the changelog
@akokhan, @mkbalani: please review this first
@lguohan: please review and merge this