Skip to content

Fixes test_dns_resolv_conf.py failures due to stale DNS config in some of the containers #26188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purush-nexthop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes test_dns_resolv_conf.py failures due to stale DNS config in some of the containers #26188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions files/image_config/resolv-config/update-containers
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,6 @@ if [[ $# -gt 0 ]]; then
exit $?
fi

# Check if networking service is active (only for bulk updates)
networking_status=$(systemctl is-active networking.service 2>/dev/null)
Copy link
Copy Markdown
Collaborator

@oleksandrivantsiv oleksandrivantsiv Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will affect the performance of the config reload command, as it will run an additional bulk update for all containers after the networking service is stopped.

Is the issue you are trying to fix a recent degradation?

Copy link
Copy Markdown
Collaborator

@oleksandrivantsiv oleksandrivantsiv Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the following PRs. They fix similar issues:
#25991
sonic-net/sonic-utilities#4365

Copy link
Copy Markdown
Author

@purush-nexthop purush-nexthop Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this.
No, this change is not to fix the degradation. During config reload (after removing the DNS config), some of the containers come up with stale config and they never get updated (as update_containers was bailing out becos of the networking check). Let me take a look at the PRs you posted and see if it could help here.

if [[ $networking_status != "active" ]]; then
log_message "info" "Networking service is not active, skipping container updates"
exit 0
fi

# If no container name provided, update only running containers
log_message "info" "Starting resolv.conf update for running containers"

Expand Down
Loading