Brcm containers migrate to trixie#25942
Open
geans-pin wants to merge 1 commit intosonic-net:masterfrom
Open
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
geans-pin
force-pushed
the
BRCM_Containers_migration_trixie
branch
from
2e297ad to
543311f
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
geans-pin
changed the title
geans-pin
force-pushed
the
BRCM_Containers_migration_trixie
branch
from
543311f to
cf5defd
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sigabrtv1-ui
pushed a commit
to sigabrtv1-ui/sonic-buildimage
that referenced
this pull request
Mar 8, 2026
…i-watchdog to Debian Trixie Update base image references from docker-config-engine-bookworm to docker-config-engine-trixie for all three gnmi-related containers. Move them from SONIC_BOOKWORM_DOCKERS to SONIC_TRIXIE_DOCKERS to align with the ongoing container migration to Debian 13 (Trixie). This follows the same pattern as PR sonic-net#25942 (Brcm containers migrate to trixie) and builds on the Trixie base layers added in PR sonic-net#25184. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
This was referenced Mar 8, 2026
Contributor
|
/azpw ms_conflict |
saiarcot895
reviewed
Mar 11, 2026
| DOCKER_SYNCD_PLATFORM_CODE = brcm | ||
| include $(PLATFORM_PATH)/../template/docker-syncd-bookworm.mk | ||
|
|
||
| include $(PLATFORM_PATH)/../template/docker-syncd-trixie.mk |
Contributor
Author
There was a problem hiding this comment.
Saiarcot,
This is platform common template file for trixie but not broadcom specific. Can you provide the template for trixie as you did for bookworm before ?
=> e15a1aa
Geans
Contributor
There was a problem hiding this comment.
#25677 has a version for Trixie that could work. Please test that version and verify that it works.
Additionally, have you done a local build of the changes here?
Contributor
Author
There was a problem hiding this comment.
yes, I've done a local build and Loaded docker-syncd-brcm and performed library dependency check. Actually, I already had a template docker-syncd-trixie.mk created in my local as the one in PR#25677 but didn't push to PR since this is common file which is out of my PR scope.
Geans
Contributor
There was a problem hiding this comment.
Could you please push that file as well?
Contributor
|
/azpw ms_conflict |
sigabrtv1-ui
pushed a commit
to sigabrtv1-ui/sonic-buildimage
that referenced
this pull request
Mar 16, 2026
…i-watchdog to Debian Trixie Update base image references from docker-config-engine-bookworm to docker-config-engine-trixie for all three gnmi-related containers. Move them from SONIC_BOOKWORM_DOCKERS to SONIC_TRIXIE_DOCKERS to align with the ongoing container migration to Debian 13 (Trixie). This follows the same pattern as PR sonic-net#25942 (Brcm containers migrate to trixie) and builds on the Trixie base layers added in PR sonic-net#25184. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
geans-pin
force-pushed
the
BRCM_Containers_migration_trixie
branch
from
cf5defd to
375458f
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
geans-pin
force-pushed
the
BRCM_Containers_migration_trixie
branch
from
375458f to
5e4a5b5
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@saiarcot895 Can you help to approve the review for merging ? |
hdwhdw
added a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Apr 1, 2026
…i-watchdog to Debian Trixie Update base image references from docker-config-engine-bookworm to docker-config-engine-trixie for all three gnmi-related containers. Move them from SONIC_BOOKWORM_DOCKERS to SONIC_TRIXIE_DOCKERS to align with the ongoing container migration to Debian 13 (Trixie). This follows the same pattern as PR sonic-net#25942 (Brcm containers migrate to trixie) and builds on the Trixie base layers added in PR sonic-net#25184. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Upgrade BRCM-related containers (PDE and SYNCD) to support Debian Trixie (Debian 13).
Work item tracking
Microsoft ADO (number only): [N/A]
How I did it
Container Base Image Update: Updated Dockerfile.j2 for both docker-pde and docker-syncd-brcm
to reference the Trixie base engine.
Python Environment Fix:
Added --break-system-packages to pip3 install commands to comply with PEP 668 in Debian Trixie. This allows overriding system-installed packages (like jsonschema) with required versions from Python wheels.
Added --no-install-recommends to apt-get install to prevent unnecessary systemd/udev bloat and potential conflicts during the build process.
Dependency Alignment: Ensured all Debian package dependencies and Python wheels are correctly resolved within the Trixie environment.
How to verify it
Validated the generated images on a Trixie build
Build Success: Successfully generated target/docker-pde.gz and target/docker-syncd-brcm.gz.
PDE Validation:
Loaded docker-pde and verified jsonschema version.
Command: docker run --rm --entrypoint /bin/bash docker-pde -c "pip3 show jsonschema"
Result: Version 2.6.0 (Correctly overrode the system's 4.19.2).
SYNCD-BRCM Validation:
Loaded docker-syncd-brcm and performed library dependency check.
Command: docker run --rm --entrypoint /bin/bash docker-syncd-brcm -c "ldd /usr/bin/syncd"
Result: All shared libraries (including libsai.so.1 and Trixie-specific glibc/boost) are fully resolved with no "not found" errors.