Always install bash-completion in image#25912
Merged
lguohan merged 1 commit intosonic-net:masterfrom Mar 7, 2026
Merged
Conversation
With sonic-net/sonic-utilities#4163, the bash-completion package was moved from Requires to Suggests. This means that it won't be installed by default. Make sure we install it always, so that completions work. Signed-off-by: Saikrishna Arcot <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that the bash-completion package is always installed in the SONiC image. After sonic-utilities moved bash-completion from Requires to Suggests (sonic-net/sonic-utilities#4163), it would no longer be installed by default, breaking shell completions.
Changes:
- Added
bash-completionto the explicit package install list inbuild_debian.sh. - Updated a comment in
sonic_debian_extension.j2to remove the now-outdated reference tosonic-utilities-datainstallingbash-completionas a dependency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
build_debian.sh |
Adds bash-completion to the base apt-get install list so it is always present in the image. |
files/build_templates/sonic_debian_extension.j2 |
Updates comment to remove stale reference to sonic-utilities-data pulling in bash-completion. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
approved these changes
Mar 6, 2026
Contributor
|
@liat-grozovik I thought there was some issue with installing this by default? On wimpy CPU platform like 2700 we had issue before? |
Collaborator
|
Cherry-pick PR to 202511: #25948 |
jackson-micas
pushed a commit
to jackson-micas/sonic-buildimage
that referenced
this pull request
Mar 10, 2026
With sonic-net/sonic-utilities#4163, the bash-completion package was moved from Requires to Suggests. This means that it won't be installed by default. Make sure we install it always, so that completions work. Signed-off-by: Saikrishna Arcot <[email protected]> Signed-off-by: jackson <[email protected]>
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
With sonic-net/sonic-utilities#4163, the bash-completion package was moved from Requires to Suggests. This means that it won't be installed by default.
Work item tracking
How I did it
Make sure we install it always in
build_debian.sh, so that completions work.How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)