ci: fix s360 security vulnerability by auspham · Pull Request #25876 · sonic-net/sonic-buildimage

auspham · 2026-03-04T04:17:39Z

Why I did it

Due to the recent s360 vulnerability reports. This PR is needed to address the problems. We have vulnerability in the follow image:

docker-ptf
debian
docker-sonic-mgmt

Work item tracking

Microsoft ADO (number only): 36979761

How I did it

Apply the recommended version from security report

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mssonicbld · 2026-03-04T04:18:07Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-04T04:18:19Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR aims to address reported S360 security vulnerabilities by updating selected dependency versions used by the docker-ptf build and its published version manifest.

Changes:

Bump pip and setuptools versions in the docker-ptf py3 versions manifest.
Update docker-ptf image build inputs (grpcurl, ipython, tac_plus, protobuf pin, gnoic).
Update the gnxi patch to require a newer protobuf for gnmi_cli_py.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
files/build/versions-public/dockers/docker-ptf/versions-py3	Updates published python package versions for docker-ptf py3.
dockers/docker-ptf/gnxi-patches/0005-Enhance-gnmi_cli_py-4.patch	Updates gnxi `gnmi_cli_py` requirements (protobuf) in the applied patch.
dockers/docker-ptf/Dockerfile.j2	Updates several pinned tool/component versions and adjusts protobuf pinning behavior.

Comments suppressed due to low confidence (1)

dockers/docker-ptf/Dockerfile.j2:115

This Dockerfile downloads the grpcurl binary directly from GitHub using curl and installs it into the image without any integrity verification (no checksum or signature check). If the upstream GitHub release or the network path is compromised, a malicious binary could be embedded into the container and later executed with its privileges. To harden the supply chain, pin this download to a specific immutable artifact and verify its integrity (for example by checking a known SHA-256 digest) before installing.

    && GRPCURL_VERSION=1.9.3 && \
    curl -L "https://github.com/fullstorydev/grpcurl/releases/download/v${GRPCURL_VERSION}/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz" \
      -o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
    cd /tmp && \
    tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
    mv grpcurl /usr/local/bin/grpcurl && \
    chmod +x /usr/local/bin/grpcurl && \

files/build/versions-public/dockers/docker-ptf/versions-py3

dockers/docker-ptf/Dockerfile.j2

mssonicbld · 2026-03-04T04:58:53Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-04T04:59:04Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

files/build/versions-public/dockers/docker-ptf/versions-py3

dockers/docker-ptf/gnxi-patches/0005-Enhance-gnmi_cli_py-4.patch

dockers/docker-ptf/Dockerfile.j2

files/build/versions-public/dockers/docker-ptf/versions-py3

mssonicbld · 2026-03-04T23:02:59Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-04T23:03:10Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-03-04T23:33:03Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-04T23:33:15Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

dockers/docker-ptf/Dockerfile.j2:115

This build step downloads a prebuilt grpcurl binary from GitHub and installs it directly into the image without verifying a checksum or signature. A compromise of the release artifact or a successful MITM attack on that URL would allow arbitrary code to be added to the image and executed as root. Fetch a specific release artifact and validate its hash (or signature) before installation, or vendor the binary into the build context instead of downloading it at build time.

    && GRPCURL_VERSION=1.9.3 && \
    curl -L "https://github.com/fullstorydev/grpcurl/releases/download/v${GRPCURL_VERSION}/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz" \
      -o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
    cd /tmp && \
    tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
    mv grpcurl /usr/local/bin/grpcurl && \
    chmod +x /usr/local/bin/grpcurl && \

dockers/docker-ptf/Dockerfile.j2:163

This Docker build clones and installs scapy-vxlan from GitHub without pinning to an immutable commit or verifying the code’s integrity. If the upstream repository or its default branch is compromised, a malicious commit could be pulled into builds and executed as root inside the container. Pin this dependency to a specific commit SHA or vetted archive and, ideally, verify its hash before running python setup.py install.

    && git clone https://github.com/p4lang/scapy-vxlan.git \
    && cd scapy-vxlan \
    && python setup.py install \
    && cd .. \
    && rm -fr scapy-vxlan \

dockers/docker-ptf/Dockerfile.j2

files/build/versions-public/dockers/docker-ptf/versions-py3

dockers/docker-ptf/Dockerfile.j2

mssonicbld · 2026-03-05T05:45:03Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-05T05:45:16Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-03-05T06:13:03Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-05T06:13:16Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

dockers/docker-ptf/Dockerfile.j2

Copilot · 2026-03-05T06:18:15Z

dockers/dockerfile-macros.j2

@@ -41,7 +41,7 @@ COPY \
 {% macro install_offending_packages(packages) -%}
    {%- for pkg in packages %}
        RUN pip3 install {{ pkg }}
-        RUN pip3 install setuptools==51.0.0
+        RUN pip3 install setuptools>=65.5.1


pip3 install setuptools>=65.5.1 will be parsed by the shell as output redirection because of the unquoted > character, so it will not apply the intended version constraint (and may create a stray file named =65.5.1 in the image). Quote or escape the requirement spec (and consider adding --upgrade) so pip reliably installs a non-vulnerable setuptools version.

Suggested change

RUN pip3 install setuptools>=65.5.1

RUN pip3 install --upgrade 'setuptools>=65.5.1'

dockers/docker-ptf/Dockerfile.j2

mssonicbld · 2026-03-05T10:57:59Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-05T10:58:13Z

Azure Pipelines successfully started running 1 pipeline(s).

dockers/docker-base-bookworm/Dockerfile.j2

mssonicbld · 2026-03-10T10:13:11Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-10T10:13:24Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Copilot · 2026-03-10T10:18:29Z

dockers/docker-ptf/Dockerfile.j2

+# Since gnxi were generated with proto 3.x we need to regenerate _pb2 with the new proto version
 RUN cd gnxi \
-    && quilt push -a
+    && quilt push -a \
+    && cd gnmi_cli_py \
+    && wget -q -O gnmi_ext.proto https://raw.githubusercontent.com/openconfig/gnmi/master/proto/gnmi_ext/gnmi_ext.proto \
+    && wget -q -O gnmi.proto https://raw.githubusercontent.com/openconfig/gnmi/master/proto/gnmi/gnmi.proto \
+    && sed -i 's|github.com/openconfig/gnmi/proto/gnmi_ext/gnmi_ext.proto|gnmi_ext.proto|' gnmi.proto \
+    && python -m grpc_tools.protoc -I. --python_out=. --grpc_python_out=. gnmi_ext.proto gnmi.proto \
+    && rm -f gnmi.proto gnmi_ext.proto


The gnxi/gnmi_cli_py installation differs by PTF_ENV_PY_VER: in the else branch (non-"mixed", including the default bookworm/py3 image) the Dockerfile no longer runs pip install -r requirements.txt. That means gnmi_cli_py dependencies won't be installed, and the gNMI client setup will likely be incomplete even though the proto stubs are regenerated. Add the requirements installation back in this branch (before/after regenerating the stubs as appropriate).

Copilot · 2026-03-10T10:18:30Z

dockers/docker-ptf/Dockerfile.j2

+# Security fixes: upgrade vulnerable system packages (S360 scan remediation)
+RUN apt-get update && apt-get install -y --only-upgrade \
+        telnet               \
+        inetutils-telnet     \
+    && rm -rf /var/lib/apt/lists/*


This block introduces another apt-get update + upgrade step, but earlier in the Dockerfile the image already runs apt-get upgrade and apt-get dist-upgrade before installing packages. Keeping an extra upgrade layer here is redundant and increases build time/layer count; consider removing it or folding the needed package remediation into the first apt step.

Copilot · 2026-03-10T10:18:30Z

dockers/docker-ptf/Dockerfile.j2

+    && wget -q -O gnmi_ext.proto https://raw.githubusercontent.com/openconfig/gnmi/master/proto/gnmi_ext/gnmi_ext.proto \
+    && wget -q -O gnmi.proto https://raw.githubusercontent.com/openconfig/gnmi/master/proto/gnmi/gnmi.proto \
+    && sed -i 's|github.com/openconfig/gnmi/proto/gnmi_ext/gnmi_ext.proto|gnmi_ext.proto|' gnmi.proto \
+    && python -m grpc_tools.protoc -I. --python_out=. --grpc_python_out=. gnmi_ext.proto gnmi.proto \


This branch downloads gnmi.proto and gnmi_ext.proto directly from the openconfig/gnmi master branch at build time. That makes builds non-reproducible and introduces supply-chain risk (content can change without notice). Please pin these downloads to a specific commit/tag (and ideally verify with a checksum) or vendor the proto files in-repo.

dockers/docker-base-bookworm/Dockerfile.j2

dockers/docker-ptf/Dockerfile.j2

auspham · 2026-03-11T00:27:29Z

/azpw run

mssonicbld · 2026-03-11T00:27:31Z

/AzurePipelines run

azure-pipelines · 2026-03-11T00:27:45Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Austin Pham <austinpham@microsoft.com>

mssonicbld · 2026-03-12T01:23:36Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-03-12T01:23:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Why I did it After #25876, there are still some left over vulnerabilities. Majority is gnoic and go library. Some new introduces by the upgrade of protobuf==6.31.1. This PR will try to address them Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham requested a review from lguohan as a code owner March 4, 2026 04:17

Copilot AI review requested due to automatic review settings March 4, 2026 04:17

Copilot started reviewing on behalf of auspham March 4, 2026 04:18 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

auspham force-pushed the austinpham/36979761-s360-resolve branch from f9428e8 to d9f6707 Compare March 4, 2026 04:58

auspham requested a review from Copilot March 4, 2026 05:00

Copilot started reviewing on behalf of auspham March 4, 2026 05:00 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

auspham force-pushed the austinpham/36979761-s360-resolve branch from d9f6707 to f2eef60 Compare March 4, 2026 23:02

auspham force-pushed the austinpham/36979761-s360-resolve branch from f2eef60 to eb467f8 Compare March 4, 2026 23:32

Copilot AI review requested due to automatic review settings March 4, 2026 23:32

Copilot started reviewing on behalf of auspham March 4, 2026 23:33 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

dockers/docker-ptf/Dockerfile.j2 Outdated Show resolved Hide resolved

dockers/docker-ptf/Dockerfile.j2 Show resolved Hide resolved

dockers/docker-ptf/Dockerfile.j2 Show resolved Hide resolved

wangxin reviewed Mar 5, 2026

View reviewed changes

files/build/versions-public/dockers/docker-ptf/versions-py3 Show resolved Hide resolved

dockers/docker-ptf/Dockerfile.j2 Show resolved Hide resolved

dockers/docker-ptf/Dockerfile.j2 Outdated Show resolved Hide resolved

auspham force-pushed the austinpham/36979761-s360-resolve branch from eb467f8 to 1b467c8 Compare March 5, 2026 05:44

Copilot AI review requested due to automatic review settings March 5, 2026 06:12

auspham force-pushed the austinpham/36979761-s360-resolve branch from 1b467c8 to d575cf7 Compare March 5, 2026 06:12

auspham requested a review from qiluo-msft as a code owner March 5, 2026 06:12

Copilot AI reviewed Mar 5, 2026

View reviewed changes

auspham force-pushed the austinpham/36979761-s360-resolve branch from d575cf7 to 0bf76a8 Compare March 5, 2026 10:57

wangxin reviewed Mar 5, 2026

View reviewed changes

dockers/docker-base-bookworm/Dockerfile.j2 Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 10, 2026 10:13

auspham force-pushed the austinpham/36979761-s360-resolve branch from 0bf76a8 to cb6b282 Compare March 10, 2026 10:13

Copilot started reviewing on behalf of auspham March 10, 2026 10:13 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

ci: fix s360 security vulnerability

8299cef

Signed-off-by: Austin Pham <austinpham@microsoft.com>

auspham force-pushed the austinpham/36979761-s360-resolve branch from cb6b282 to 8299cef Compare March 12, 2026 01:23

wangxin approved these changes Mar 12, 2026

View reviewed changes

wangxin merged commit 28495fc into sonic-net:master Mar 12, 2026
20 checks passed

auspham added the Request for 202511 Branch label Mar 16, 2026

mssonicbld added the Cherry Pick Conflict_202511 label Mar 16, 2026

auspham added the Request for 202505 Branch label Mar 16, 2026

mssonicbld added the Cherry Pick Conflict_202505 label Mar 16, 2026

This was referenced Mar 16, 2026

[202511] ci: fix s360 security vulnerability cherry-pick 25876 #26198

Merged

[202505] ci: fix s360 security vulnerability #26200

Merged

s360: Resolve library vulnerabilty #26161

Merged

This was referenced Mar 23, 2026

ci: fix IPython and Werkzeug vulnerability #26325

Merged

[202411] Fix 202411 vulnerability #26326

Open

	RUN pip3 install setuptools>=65.5.1
	RUN pip3 install --upgrade 'setuptools>=65.5.1'

Conversation

auspham commented Mar 4, 2026

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented Mar 4, 2026

Uh oh!

azure-pipelines bot commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 4, 2026

Uh oh!

azure-pipelines bot commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 4, 2026

Uh oh!

azure-pipelines bot commented Mar 4, 2026

Uh oh!

mssonicbld commented Mar 4, 2026

Uh oh!

azure-pipelines bot commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 5, 2026

Uh oh!

azure-pipelines bot commented Mar 5, 2026

Uh oh!

mssonicbld commented Mar 5, 2026

Uh oh!

azure-pipelines bot commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Mar 5, 2026

Uh oh!

azure-pipelines bot commented Mar 5, 2026

Uh oh!

Uh oh!