Fixed restapi.service_branch files inside docker-restapi-sidecar#25429
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Feb 19, 2026
Merged
Fixed restapi.service_branch files inside docker-restapi-sidecar#25429qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the restapi.service systemd service files across multiple SONiC branches to change the User from "admin" to "root", which is required for Kubernetes pod rollout operations. Additionally, it adds DPU environment variables (NUM_DPU and IS_DPU_DEVICE) to the 202505 branch and removes the unused base restapi.service file.
Changes:
- Updated User directive from "admin" to "root" in all branch-specific service files (202311, 202405, 202411, 202505, 202511)
- Added NUM_DPU and IS_DPU_DEVICE environment variables to restapi.service_202505
- Removed the base restapi.service file which was unused since branch-specific files are selected at runtime
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| restapi.service_202511 | Changed User from admin to root for k8s operations |
| restapi.service_202505 | Changed User to root and added DPU environment variables |
| restapi.service_202411 | Changed User from admin to root for k8s operations |
| restapi.service_202405 | Changed User from admin to root for k8s operations |
| restapi.service_202311 | Changed User from admin to root for k8s operations |
| restapi.service | Removed unused base service file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maipbui
approved these changes
Feb 11, 2026
FengPan-Frank
approved these changes
Feb 11, 2026
|
hi @qiluo-msft looks like changes are approved. Does this need a merge? TY! |
Collaborator
Author
Just merged it. |
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…ic-net#25429) Why I did it Fix restapi.service_202505 with DPU env vars. Fix User setting in restapi.service_BRANCH files, the change is required to operate k8s rollout containers. Work item tracking Microsoft ADO (number only): How I did it How to verify it Manually tested on 202505 DUT, checked /usr/lib/systemd/system/restapi.service is expected to be override with changes. Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
) Why I did it Fix restapi.service_202505 with DPU env vars. Fix User setting in restapi.service_BRANCH files, the change is required to operate k8s rollout containers. Work item tracking Microsoft ADO (number only): How I did it How to verify it Manually tested on 202505 DUT, checked /usr/lib/systemd/system/restapi.service is expected to be override with changes. Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix restapi.service_202505 with DPU env vars.
Fix User setting in restapi.service_BRANCH files, the change is required to operate k8s rollout containers.
Work item tracking
How I did it
How to verify it
Manually tested on 202505 DUT, checked /usr/lib/systemd/system/restapi.service is expected to be override with changes.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)