[202511] Backport PR #22486: sonic dhcp relay agent for IPv4#25371
[202511] Backport PR #22486: sonic dhcp relay agent for IPv4#25371vmittal-msft merged 8 commits intosonic-net:202511from
Conversation
Why I did it Currently SONiC uses the 'isc-dhcp-relay' package to allow DHCP relay functionality on IPv4 networks. With this PR we are adding sonic dhcp relay agent for IPv4 as described in this HLD(sonic-net/SONiC#1938) Work item tracking Microsoft ADO (number only): How I did it Edit supervisord template to start sonic DHCPv4 relay instance when configured to do so in Config DB. Align cfg unit test to the new change. How to verify it Configure sonic DHCPv4 agent as described in the feature HLD(sonic-net/SONiC#1938) Test it with real client/server with IPv4 or use the sonic-mgmt suite Signed-off-by: Ashutosh Agrawal <ashu@cisco.com> Co-authored-by: Shivashankar C R <shivashankar.c.r@gmail.com> Co-authored-by: Ashutosh Agrawal <ashu@cisco.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: StormLiangMS <89824293+StormLiangMS@users.noreply.github.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
FYI from the checks it seems like there are build failures for all platforms. Ex for broadcom: |
|
@dayouliu1 @vmittal-msft @Blueve I think build failures are due to Boost library dependency. We probably need to backport PR#87 and PR#88 to fix it. Also, PR#84 needs to be backported for functional bug fixes. |
|
Manual backport of #87 and #88 to 202511 if needed: |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ashutosh-agrawal can you please check failures ? |
|
@vmittal-msft We need the following PR to be merged to fix the build issues. @dayouliu1 had earlier opened two separate PRs for the changes but both set of changes are required together to pass the CI on sonic-dhcp-relay repo. Once you merge the above PR, I'll update the refpoint to sonic-dhcp-relay in this PR. |
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict |
3 similar comments
|
/azpw ms_conflict |
|
/azpw ms_conflict |
|
/azpw ms_conflict |
|
/azpw retry |
|
Retrying failed(or canceled) jobs... |
|
Retrying failed(or canceled) stages in build 1067549:
|
|
/azpw ms_conflict |
Backport of #22486 to 202511
This PR backports the sonic DHCPv4 relay agent functionality from master to the 202511 branch.
Original PR
Changes
sonic-device_metadata.yang(addedzebra_nexthopfield specific to 202511)dhcprelayd.pyfor consistencyWhat was added
dhcp4relay)has_sonic_dhcpv4_relayin DEVICE_METADATATesting
How to verify
Configure sonic DHCPv4 agent as described in the feature HLD: sonic-net/SONiC#1938