[build] Fix docker-telemetry-sidecar missing sonic_py_common dependency issue.#25225
Merged
liushilongbuaa merged 4 commits intosonic-net:masterfrom Jan 29, 2026
Merged
Conversation
FengPan-Frank
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit build-time dependency on sonic_py_common for the telemetry sidecar Docker image to avoid missing-wheel issues in dedicated pipeline runs.
Changes:
- Add
sonic_py_commonas an explicitly installed Python wheel fordocker-telemetry-sidecarbuilds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qiluo-msft
approved these changes
Jan 28, 2026
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 tasks
liushilongbuaa
changed the title
hdwhdw
added a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
The sidecar uses sonic_py_common.sidecar_common library which needs to be explicitly installed as a Python wheel. This mirrors the fix in PR sonic-net#25225 for docker-telemetry-sidecar. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
…cy issue. (sonic-net#25225) Signed-off-by: Xincun Li <stli@microsoft.com>
FengPan-Frank
added a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…cy issue. (sonic-net#25225) Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…cy issue. (#25225) Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix sonic_py_common dependency issue in dedicated pipeline run, buildimage is good since bookworm image has built and contained sonic_py_common.
Work item tracking
How I did it
Add sonic_py_common explicit dependency.
How to verify it
pipeline verified.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)