[ssw] clean up DPU_APPL_DB and DPU_STATE_DB for DPU swss restart or DPU reboot by zjswhhh · Pull Request #25187 · sonic-net/sonic-buildimage

zjswhhh · 2026-01-26T02:56:14Z

reference: https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-device_metadata.yang#L197

Why I did it

For sonic-net/SONiC#2175

sign-off: Jing Zhang [email protected]

Work item tracking

Microsoft ADO (number only):

How I did it

Check if DPU_APPL_DB is pingable
If yes, flush all DB entries when swss starts.

How to verify it

Tested on ssw testbed.

Entries got removed.

$ redis-cli -p 6381 -n 15 
127.0.0.1:6381[15]> keys *
1) "BFD_SESSION_TABLE:default:default:10.1.0.32"
2) "BFD_SESSION_TABLE:default:default:10.1.2.32"
3) "BFD_SESSION_TABLE:default:default:10.1.1.32"
127.0.0.1:6381[15]> keys *
(empty array)

$ redis-cli  -p 6381 MONITOR
OK

... ...
1769395816.952661 [18 169.254.200.1:34286] "PING"
1769395816.952718 [16 169.254.200.1:34280] "PING"
1769395816.954712 [17 169.254.200.1:34296] "SELECT" "17"
1769395816.954877 [17 169.254.200.1:34296] "PING"
1769395817.183169 [15 169.254.200.1:34310] "SELECT" "15"
1769395817.183386 [15 169.254.200.1:34310] "PING"
1769395817.210425 [15 169.254.200.1:34320] "SELECT" "15"
1769395817.210602 [15 169.254.200.1:34320] "FLUSHDB"
1769395817.229074 [17 169.254.200.1:34322] "SELECT" "17"
1769395817.229309 [17 169.254.200.1:34322] "FLUSHDB"

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mssonicbld · 2026-01-26T02:56:22Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-26T02:56:33Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-26T02:58:09Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-26T02:58:20Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This pull request adds database cleanup logic for DPU (Data Processing Unit) remote databases during swss service restart. The implementation checks if DPU_APPL_DB is reachable and flushes both DPU_APPL_DB and DPU_STATE_DB when swss starts, ensuring a clean state after DPU swss restart or DPU reboot.

Changes:

Added conditional check to detect if DPU_APPL_DB is pingable before flushing
Implemented flush logic for DPU_APPL_DB and DPU_STATE_DB within the existing warm boot protection block
Added debug logging for DPU database cleanup operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

files/scripts/swss.sh

prabhataravind · 2026-01-26T08:01:53Z

@zjswhhh can we make sure we do this check only for smartswitch DPUs and not for any other platforms to avoid unnecessary delays in swss startup? Please also confirm that the change flushes only the DBs associated with the DPU that restarted and that the rest of the online DPU databases are unaffected..

mssonicbld · 2026-01-27T18:46:58Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-27T18:47:10Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-28T01:46:50Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-28T01:47:02Z

Azure Pipelines successfully started running 1 pipeline(s).

zjswhhh · 2026-01-28T01:47:07Z

Hi @prabhataravind - please help review again.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

files/scripts/swss.sh

mssonicbld · 2026-01-28T20:06:23Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-28T20:06:39Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

files/scripts/swss.sh

mssonicbld · 2026-02-18T00:23:48Z

/azp run Azure.sonic-buildimage

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

files/scripts/swss.sh

Copilot · 2026-02-18T00:23:56Z

files/scripts/swss.sh

+                $SONIC_DB_CLI DPU_APPL_DB FLUSHDB
+                $SONIC_DB_CLI DPU_STATE_DB FLUSHDB
+                $SONIC_DB_CLI DPU_APPL_STATE_DB FLUSHDB
+                $SONIC_DB_CLI DPU_COUNTERS_DB FLUSHDB


The DPU DB flushes are performed without checking the return code. Since these can target the remote_redis instance, a transient connectivity issue could leave stale entries behind without any clear indication of which FLUSHDB failed. Consider checking each FLUSHDB command’s exit status and logging failures (or failing fast) to make swss restart behavior deterministic and debuggable.

Suggested change

$SONIC_DB_CLI DPU_APPL_DB FLUSHDB

$SONIC_DB_CLI DPU_STATE_DB FLUSHDB

$SONIC_DB_CLI DPU_APPL_STATE_DB FLUSHDB

$SONIC_DB_CLI DPU_COUNTERS_DB FLUSHDB

if ! $SONIC_DB_CLI DPU_APPL_DB FLUSHDB; then

debug "Failed to flush DPU_APPL_DB via FLUSHDB"

exit 1

fi

if ! $SONIC_DB_CLI DPU_STATE_DB FLUSHDB; then

debug "Failed to flush DPU_STATE_DB via FLUSHDB"

exit 1

fi

if ! $SONIC_DB_CLI DPU_APPL_STATE_DB FLUSHDB; then

debug "Failed to flush DPU_APPL_STATE_DB via FLUSHDB"

exit 1

fi

if ! $SONIC_DB_CLI DPU_COUNTERS_DB FLUSHDB; then

debug "Failed to flush DPU_COUNTERS_DB via FLUSHDB"

exit 1

fi

azure-pipelines · 2026-02-18T00:24:00Z

Azure Pipelines successfully started running 1 pipeline(s).

zjswhhh · 2026-02-18T18:07:51Z

/azpw ms_conflict

mssonicbld · 2026-02-18T18:41:07Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-02-18T18:41:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jing Zhang <[email protected]>

mssonicbld · 2026-02-18T23:08:18Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-02-18T23:08:31Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

mssonicbld · 2026-02-19T15:42:18Z

Cherry-pick PR to 202511: #25578

…PU reboot (sonic-net#25187) [ssw] clean up DPU_APPL_DB and DPU_STATE_DB for DPU swss restart or DPU reboot (sonic-net#25187) Signed-off-by: Feng Pan <[email protected]>

…PU reboot (#25187) [ssw] clean up DPU_APPL_DB and DPU_STATE_DB for DPU swss restart or DPU reboot (#25187) Signed-off-by: dprital <[email protected]>

zjswhhh requested a review from lguohan as a code owner January 26, 2026 02:56

Copilot AI review requested due to automatic review settings January 26, 2026 02:56

Copilot started reviewing on behalf of zjswhhh January 26, 2026 02:56 View session

zjswhhh requested review from prabhataravind, prsunny, vivekrnv and yue-fred-gao January 26, 2026 02:57

Copilot AI reviewed Jan 26, 2026

View reviewed changes

files/scripts/swss.sh Outdated Show resolved Hide resolved

files/scripts/swss.sh Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 28, 2026 01:46

Copilot started reviewing on behalf of zjswhhh January 28, 2026 01:47 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

prsunny reviewed Jan 28, 2026

View reviewed changes

files/scripts/swss.sh Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 28, 2026 20:06

Copilot started reviewing on behalf of zjswhhh January 28, 2026 20:06 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

files/scripts/swss.sh Outdated Show resolved Hide resolved

zjswhhh requested a review from prsunny January 28, 2026 20:24

zjswhhh added the Request for 202511 Branch label Jan 28, 2026

prsunny requested a review from theasianpianist January 28, 2026 21:38

Copilot AI reviewed Feb 18, 2026

View reviewed changes

kperumalbfn approved these changes Feb 18, 2026

View reviewed changes

zjswhhh force-pushed the dpu_restart branch from 556dae2 to e5826d6 Compare February 18, 2026 18:40

zjswhhh and others added 5 commits February 19, 2026 07:07

flush dpu db when dpu restart

6a3e39e

Signed-off-by: Jing Zhang <[email protected]>

check if pingable

bd138ac

Signed-off-by: Jing Zhang <[email protected]>

address commetns

d06715c

Signed-off-by: Jing Zhang <[email protected]>

Update comment from DPU to NPU in swss.sh

752839a

Signed-off-by: Jing Zhang <[email protected]>

check if it's dpu

d8bc30d

Signed-off-by: Jing Zhang <[email protected]>

Copilot AI review requested due to automatic review settings February 18, 2026 23:07

zjswhhh force-pushed the dpu_restart branch from e5826d6 to d8bc30d Compare February 18, 2026 23:07

Copilot started reviewing on behalf of zjswhhh February 18, 2026 23:08 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

kperumalbfn merged commit 0250a88 into sonic-net:master Feb 19, 2026
29 of 30 checks passed

mssonicbld mentioned this pull request Feb 19, 2026

[action] [PR:25187] [ssw] clean up DPU_APPL_DB and DPU_STATE_DB for DPU swss restart or DPU reboot #25578

Merged

8 tasks

mssonicbld added the Created PR to 202511 Branch label Feb 19, 2026

mssonicbld added Included in 202511 Branch and removed Created PR to 202511 Branch labels Feb 19, 2026

-                $SONIC_DB_CLI DPU_APPL_DB FLUSHDB
-                $SONIC_DB_CLI DPU_STATE_DB FLUSHDB
-                $SONIC_DB_CLI DPU_APPL_STATE_DB FLUSHDB
-                $SONIC_DB_CLI DPU_COUNTERS_DB FLUSHDB
+                if ! $SONIC_DB_CLI DPU_APPL_DB FLUSHDB; then
+                    debug "Failed to flush DPU_APPL_DB via FLUSHDB"
+                    exit 1
+                fi
+                if ! $SONIC_DB_CLI DPU_STATE_DB FLUSHDB; then
+                    debug "Failed to flush DPU_STATE_DB via FLUSHDB"
+                    exit 1
+                fi
+                if ! $SONIC_DB_CLI DPU_APPL_STATE_DB FLUSHDB; then
+                    debug "Failed to flush DPU_APPL_STATE_DB via FLUSHDB"
+                    exit 1
+                fi
+                if ! $SONIC_DB_CLI DPU_COUNTERS_DB FLUSHDB; then
+                    debug "Failed to flush DPU_COUNTERS_DB via FLUSHDB"
+                    exit 1
+                fi

Conversation

zjswhhh commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

mssonicbld commented Jan 26, 2026

Uh oh!

azure-pipelines bot commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

prabhataravind commented Jan 26, 2026

Uh oh!

mssonicbld commented Jan 27, 2026

Uh oh!

azure-pipelines bot commented Jan 27, 2026

Uh oh!

mssonicbld commented Jan 28, 2026

Uh oh!

azure-pipelines bot commented Jan 28, 2026

Uh oh!

zjswhhh commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mssonicbld commented Jan 28, 2026

Uh oh!

azure-pipelines bot commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

zjswhhh commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

zjswhhh commented Jan 26, 2026 •

edited

Loading