Update init_cfg to enable macsec on UpperSpineRouter#25153
Merged
yxieca merged 2 commits intosonic-net:masterfrom Jan 29, 2026
Merged
Update init_cfg to enable macsec on UpperSpineRouter#25153yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables macsec feature on UpperSpineRouter device types at initialization time, extending the existing support that was previously limited to SpineRouter devices. The change ensures that macsec is automatically enabled during init for both SpineRouter and UpperSpineRouter devices when the platform supports macsec capability.
Changes:
- Modified the macsec feature initialization condition to include UpperSpineRouter alongside SpineRouter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…apable Signed-off-by: Tejaswini Chadaga <[email protected]>
tjchadaga
force-pushed
the
init_cfg_fix_ut2
branch
from
5fbd37c to
5ea6340
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Jan 22, 2026
qiluo-msft
approved these changes
Jan 22, 2026
vmittal-msft
approved these changes
Jan 28, 2026
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@tjchadaga please check build failure, thanks. |
Collaborator
|
Cherry-pick PR to 202511: #25235 |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
…apable (sonic-net#25153) Why I did it To enable macsec on UpperSpineRouters when the device is capable at init time How I did it Modify init_cfg.json to enable macsec on UpperSpineRouter when platform is macsec capable How to verify it Macsec feature is enabled on supported device if it is a SpineRouter or UpperSpineRouter Signed-off-by: Tejaswini Chadaga <[email protected]> Co-authored-by: Vineet Mittal <[email protected]> Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…apable (sonic-net#25153) Why I did it To enable macsec on UpperSpineRouters when the device is capable at init time How I did it Modify init_cfg.json to enable macsec on UpperSpineRouter when platform is macsec capable How to verify it Macsec feature is enabled on supported device if it is a SpineRouter or UpperSpineRouter Signed-off-by: Tejaswini Chadaga <[email protected]> Co-authored-by: Vineet Mittal <[email protected]> Signed-off-by: Feng Pan <[email protected]>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…apable (#25153) Why I did it To enable macsec on UpperSpineRouters when the device is capable at init time How I did it Modify init_cfg.json to enable macsec on UpperSpineRouter when platform is macsec capable How to verify it Macsec feature is enabled on supported device if it is a SpineRouter or UpperSpineRouter Signed-off-by: Tejaswini Chadaga <[email protected]> Co-authored-by: Vineet Mittal <[email protected]> Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To enable macsec on UpperSpineRouters when the device is capable at init time
Work item tracking
How I did it
Modify init_cfg.json to enable macsec on UpperSpineRouter when platform is macsec capable
How to verify it
Macsec feature is enabled on supported device if it is a SpineRouter or UpperSpineRouter
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)