[Arista] UEFI boot support for Arista platform#25067
[Arista] UEFI boot support for Arista platform#25067StormLiangMS merged 4 commits intosonic-net:masterfrom
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nobutomonakano-arista
requested review from
lguohan and
qiluo-msft
as code owners
|
@nobutomonakano-arista, can you please resolve the conflict |
|
@saiarcot895, can you review this PR |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
files/initramfs-tools/swi2bin
Outdated
| ;; | ||
| esac | ||
|
|
||
| perform_swi2bin=false |
There was a problem hiding this comment.
What's the purpose of this script? Is it to convert from using aboot to using UEFI directly?
There was a problem hiding this comment.
Yes. At the initial setup of UEFI capable box, we need a special .swi image to boot from Aboot.
The special .swi image has special boot0 which sets up platform information and creates disk partitions required for UEFI boot.
The special boot0 also supplies "arista.swi2bin" kernel command line parameter, so that swi2bin script in the initramfs sets up grub and installs fs image to make box bootable with UEFI.
files/initramfs-tools/swi2bin
Outdated
| perform_swi2bin=true | ||
| verbose=true | ||
| ;; | ||
| arista.swi2bin|arista.swi2bin=*) |
There was a problem hiding this comment.
When/in what cases will this be set?
There was a problem hiding this comment.
This is set by the boot0 included in the special .swi image for the initial setup.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895, can you please help signoff, if all the comments are resolved |
| pyyaml \ | ||
| bottle |
There was a problem hiding this comment.
Please install these packages via apt instead, as python3-yaml and python3-bottle.
There was a problem hiding this comment.
@nobutomonakano-arista, can you please help resolve this comment?
There was a problem hiding this comment.
modified as suggested. Thank you.
saiarcot895
left a comment
saiarcot895
left a comment
There was a problem hiding this comment.
One comment, but otherwise LGTM
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nobutomonakano-arista
dismissed stale reviews from saiarcot895 and Staphylo
via
6976dd5
nobutomonakano-arista
force-pushed
the
master-arista-uefi
branch
from
6976dd5 to
56347b9
Compare
nobutomonakano-arista
requested review from
StormLiangMS,
dgsudharsan,
praveen-li,
venkatmahalingam and
xumia
as code owners
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
nobutomonakano-arista
force-pushed
the
master-arista-uefi
branch
from
56347b9 to
c7ed40b
Compare
|
/azp run Azure.sonic-buildimage |
Signed-off-by: Nobutomo Nakano <[email protected]>
Signed-off-by: Nobutomo Nakano <[email protected]>
Signed-off-by: Nobutomo Nakano <[email protected]>
Signed-off-by: Nobutomo Nakano <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Friendly ping — this PR is blocked and needs approval for 202511 qualification. cc @lguohan @qiluo-msft @StormLiangMS |
|
hi @saiarcot895 would you review again? |
|
@nobutomonakano-arista — This PR is merged to master (3/24) but only has 'Request for 202511 Branch' label — not yet approved for backport. Could the branch maintainers please approve the 202511 backport? Tracked in aristanetworks/sonic-qual.msft#1042. |
|
Cherry-pick PR to 202511: #26419 |
|
@nobutomonakano-arista cherry pick PR didn't pass PR checker. Please check!!! |
Why I did it UEFI boot support for Arista platforms which support UEFI boot. Work item tracking Microsoft ADO (number only): How I did it Added Arista driver packages to ONIE image. Added required change in initramfs to create necessary partitions and extract binaries at the initial boot from Aboot. How to verify it verified that sonic booted up properly with Arista platform which support UEFI boot. Signed-off-by: Nobutomo Nakano <[email protected]> Signed-off-by: arlakshm <[email protected]>
I've filed a new PR for 202511. #26532 |
7 participants
Why I did it
UEFI boot support for Arista platforms which support UEFI boot.
Work item tracking
How I did it
Added Arista driver packages to ONIE image. Added required change in initramfs to create necessary partitions and extract binaries at the initial boot from Aboot.
How to verify it
verified that sonic booted up properly with Arista platform which support UEFI boot.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)