[Mellanox] read temperature threshold from SDK sysfs for firmware-controlled module#24855
Merged
liat-grozovik merged 9 commits intosonic-net:masterfrom Jan 30, 2026
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
master-retry-threshold
branch
from
a8c3204 to
69ef6be
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
force-pushed
the
master-retry-threshold
branch
from
69ef6be to
439bfb9
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Dec 15, 2025
…trolled modules Signed-off-by: Junchao-Mellanox <[email protected]>
Junchao-Mellanox
force-pushed
the
master-retry-threshold
branch
from
439bfb9 to
6eee5a7
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Junchao-Mellanox <[email protected]>
Junchao-Mellanox
force-pushed
the
master-retry-threshold
branch
from
e4b1f4f to
fe07551
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
PR for 202511: #24937 |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
previously approved these changes
Jan 12, 2026
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Jan 30, 2026
xincunli-sonic
pushed a commit
to xincunli-sonic/sonic-buildimage
that referenced
this pull request
Feb 2, 2026
…trolled module (sonic-net#24855) - Why I did it For firmware controlled module, temperature threshold should be read from SDK sysfs to avoid too many I2C access from module. - How I did it Read temp threshold from SDK sysfs for fimrware-controlled module Add a retry mechanism to avoid reading module temperature when it is not ready - How to verify it unit test manual test passed on SPC1, SPC3, SPC4 and SPC5 sonic-mgmt regression test passed on all Nvidia platforms Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: Xincun Li <[email protected]>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…trolled module (sonic-net#24855) - Why I did it For firmware controlled module, temperature threshold should be read from SDK sysfs to avoid too many I2C access from module. - How I did it Read temp threshold from SDK sysfs for fimrware-controlled module Add a retry mechanism to avoid reading module temperature when it is not ready - How to verify it unit test manual test passed on SPC1, SPC3, SPC4 and SPC5 sonic-mgmt regression test passed on all Nvidia platforms Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: Feng Pan <[email protected]>
r12f
added
Included in 202511 Branch
Approved for 202511 Branch
and removed
Request for 202511 Branch
Cherry Pick Conflict_202511
labels
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…trolled module (#24855) - Why I did it For firmware controlled module, temperature threshold should be read from SDK sysfs to avoid too many I2C access from module. - How I did it Read temp threshold from SDK sysfs for fimrware-controlled module Add a retry mechanism to avoid reading module temperature when it is not ready - How to verify it unit test manual test passed on SPC1, SPC3, SPC4 and SPC5 sonic-mgmt regression test passed on all Nvidia platforms Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
For firmware controlled module, temperature threshold should be read from SDK sysfs to avoid too many I2C access from module.
Work item tracking
How I did it
How to verify it
unit test
manual test passed on SPC1, SPC3, SPC4 and SPC5
sonic-mgmt regression test passed on all Nvidia platforms
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)