[YANG] Add serial/console device types to YANG#24854
Merged
yxieca merged 1 commit intosonic-net:masterfrom Dec 15, 2025
Merged
Conversation
Signed-off-by: Jing Kan <jika@microsoft.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the SONiC YANG model to support six new device types for serial/console infrastructure: MiniTs, LeafTs, SpineTs, CoreTs, ConsoleServer, and TerminalServer. These additions enable the YANG model to validate configurations for terminal server and console server device roles in network topology.
- Added six new device type patterns to the YANG model's type validation regex
- Added comprehensive test configurations for each new device type
- Added test descriptions following established naming conventions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/sonic-yang-models/yang-models/sonic-device_metadata.yang | Extended the device type pattern to include MiniTs, LeafTs, SpineTs, CoreTs, ConsoleServer, and TerminalServer |
| src/sonic-yang-models/tests/yang_model_tests/tests_config/device_metadata.json | Added test configuration blocks for all six new device types with bgp_asn and type fields |
| src/sonic-yang-models/tests/yang_model_tests/tests/device_metadata.json | Added test descriptions for validating each of the six new device type patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lizhijianrd
approved these changes
Dec 15, 2025
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Signed-off-by: Jing Kan <jika@microsoft.com> Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Signed-off-by: Jing Kan <jika@microsoft.com> Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Signed-off-by: Jing Kan <jika@microsoft.com>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Signed-off-by: Jing Kan <jika@microsoft.com> Signed-off-by: Feng Pan <fenpan@microsoft.com>
Contributor
|
@Blueve Cisco console would need MiniTS in 202511, should we include this PR in 202511 branch? |
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Signed-off-by: Jing Kan <jika@microsoft.com> Signed-off-by: dprital <drorp@nvidia.com>
lizhijianrd
pushed a commit
to lizhijianrd/sonic-buildimage
that referenced
this pull request
Mar 19, 2026
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
Contributor
|
Backport 202511: #26270 |
lizhijianrd
added
Created PR to 202511 Branch
Approved for msft-202603 Branch
and removed
Cherry Pick Conflict_202511
labels
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 24, 2026
How I did it Update YANG and add related unit tests. How to verify it Unit tests are all passed. Signed-off-by: Zhijian Li <zhijianli@microsoft.com> Co-authored-by: Jing Kan <jika@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lizhijianrd
added
Approved for 202511 Branch
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
liushilongbuaa
added
Approved for msft-202603 Branch
and removed
Approved for msft-202603 Branch
labels
Contributor
|
The backport to 202603 completed via code sync from 202511. |
lizhijianrd
added
Included in msft-202603 Branch
and removed
Cherry Pick Conflict_msft-202603
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add serial/console device types to YANG model.
Work item tracking
How I did it
Update YANG and add related unit tests.
How to verify it
Unit tests are all passed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)