Removing deployment id filter from router advertiser#24785
Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom Dec 11, 2025
Merged
Removing deployment id filter from router advertiser#24785qiluo-msft merged 3 commits intosonic-net:masterfrom
qiluo-msft merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deployment ID filtering logic from the router advertiser configuration template. Previously, the router advertiser would not run on devices with deployment_id set to "8", but this restriction is now removed.
Key Changes
- Removed the conditional check for
DEVICE_METADATA.localhost.deployment_id != "8" - De-indented the nested Jinja2 template logic by one level to maintain proper structure
- Router advertiser will now run on all ToR/EPMS/MgmtTsToR devices with IPv6-enabled VLAN interfaces, regardless of deployment ID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dockers/docker-router-advertiser/docker-router-advertiser.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
dockers/docker-router-advertiser/docker-router-advertiser.supervisord.conf.j2
Outdated
Show resolved
Hide resolved
9 tasks
…rvisord.conf.j2 Co-authored-by: Copilot <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…rvisord.conf.j2 Co-authored-by: Copilot <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qiluo-msft
approved these changes
Dec 9, 2025
Collaborator
|
Please fill in some info in PR description |
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
Why I did it Removed Deployment id filter from router advertiser so as to enable IPV6 Router Advertiser on all TOR (T0) devices for all deployments which have at least one vlan interface Work item tracking Microsoft ADO (number only): 32212243 How I did it Removed Deployment id filter Signed-off-by: Dawei Huang <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
Why I did it Removed Deployment id filter from router advertiser so as to enable IPV6 Router Advertiser on all TOR (T0) devices for all deployments which have at least one vlan interface Work item tracking Microsoft ADO (number only): 32212243 How I did it Removed Deployment id filter Signed-off-by: xiaweijiang <[email protected]>
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
Why I did it Removed Deployment id filter from router advertiser so as to enable IPV6 Router Advertiser on all TOR (T0) devices for all deployments which have at least one vlan interface Work item tracking Microsoft ADO (number only): 32212243 How I did it Removed Deployment id filter
Contributor
|
@vmittal-msft Please approve for 202511 |
9 tasks
Collaborator
|
Cherry-pick PR to 202511: #25180 |
Collaborator
3 similar comments
Collaborator
Collaborator
Collaborator
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
Why I did it Removed Deployment id filter from router advertiser so as to enable IPV6 Router Advertiser on all TOR (T0) devices for all deployments which have at least one vlan interface Work item tracking Microsoft ADO (number only): 32212243 How I did it Removed Deployment id filter Signed-off-by: Feng Pan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Removed Deployment id filter from router advertiser so as to enable IPV6 Router Advertiser on all TOR (T0) devices for all deployments which have at least one vlan interface
Work item tracking
How I did it
Removed Deployment id filter
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)