Skip to content

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451#24578

Merged
kperumalbfn merged 1 commit intosonic-net:masterfrom
kewei-arista:pr-sonic.3
Nov 21, 2025
Merged

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451#24578
kperumalbfn merged 1 commit intosonic-net:masterfrom
kewei-arista:pr-sonic.3

Conversation

@kewei-arista
Copy link
Contributor

Why I did it

Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451:

Set Bit 2 in sai_stats_support_mask. (This is to enable Egress Queue drop flex counter)
Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated the BCM config file accordingly for all Orcas T1 HWSKUs.

How to verify it

Confirmed the failed test pfcwd/test_pfcwd_cli.py now can pass with this new setting and the patch provided by Broadcom, which merged to SAI 13.2.1.23.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

  • 202505

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn
Copy link
Contributor

@sdszhang We could close the other PR - #24590

@kperumalbfn kperumalbfn merged commit e94a1e1 into sonic-net:master Nov 21, 2025
22 checks passed
global:
ftem_mem_entries: 65536
#enable port queue drop stats
sai_stats_support_mask: 0x880
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kewei-arista this change reverted the PR #23772, should we update the stats_support_mask to 0x884 for both Moby and O128 hwsku?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me confirm this new value works for both Moby and O128 as bit 7 was not set for Moby. I'll update PR once I have the test result.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the comment in #24729. Note that we don't need to set bit 7 for Moby as SRv6 is not supported for Moby.

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #24632

ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
…r Broadcom CSP case 00012425451 (sonic-net#24578)

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451
hdwhdw pushed a commit to hdwhdw/sonic-buildimage that referenced this pull request Dec 2, 2025
…r Broadcom CSP case 00012425451 (sonic-net#24578)

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451
NavdhaJindal pushed a commit to NavdhaJindal/sonic-buildimage that referenced this pull request Dec 2, 2025
…r Broadcom CSP case 00012425451 (sonic-net#24578)

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451

Signed-off-by: Navdha Jindal <navdhajindal@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #24723

FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
…r Broadcom CSP case 00012425451 (sonic-net#24578)

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451

Signed-off-by: Feng Pan <fenpan@microsoft.com>
yxieca pushed a commit that referenced this pull request Dec 16, 2025
…PE-B-O128 and update comments (#24774)

Why I did it
This PR is addressing a comment in #24578 by correctly set sai_stats_support_mask for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

Signed-off-by: kewei <kewei@arista.com>
Co-authored-by: Vineet  Mittal <46945843+vmittal-msft@users.noreply.github.com>
mssonicbld added a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 18, 2025
…PE-B-O128 and update comments

<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
This PR is addressing a comment in sonic-net#24578 by correctly set `sai_stats_support_mask` for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

Confirmed pfcwd tests are passing with this change.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505
- [x] 202511

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [x] 202505

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
mssonicbld added a commit that referenced this pull request Dec 18, 2025
…PE-B-O128 and update comments (#24886)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it
This PR is addressing a comment in #24578 by correctly set `sai_stats_support_mask` for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

Confirmed pfcwd tests are passing with this change.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202505
- [x] 202511

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [x] 202505

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
hdwhdw pushed a commit to hdwhdw/sonic-buildimage that referenced this pull request Dec 18, 2025
…PE-B-O128 and update comments (sonic-net#24774)

Why I did it
This PR is addressing a comment in sonic-net#24578 by correctly set sai_stats_support_mask for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

Signed-off-by: kewei <kewei@arista.com>
Co-authored-by: Vineet  Mittal <46945843+vmittal-msft@users.noreply.github.com>
Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
…r Broadcom CSP case 00012425451 (sonic-net#24578)

[Orcas T1][TH5] Setting Broadcom setting for PFCWD counter support per Broadcom CSP case 00012425451

Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
…PE-B-O128 and update comments (sonic-net#24774)

Why I did it
This PR is addressing a comment in sonic-net#24578 by correctly set sai_stats_support_mask for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

Signed-off-by: kewei <kewei@arista.com>
Co-authored-by: Vineet  Mittal <46945843+vmittal-msft@users.noreply.github.com>
Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
jasonbridges pushed a commit to jasonbridges/sonic-buildimage that referenced this pull request Jan 22, 2026
…PE-B-O128 and update comments (sonic-net#24774)

Why I did it
This PR is addressing a comment in sonic-net#24578 by correctly set sai_stats_support_mask for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

Signed-off-by: kewei <kewei@arista.com>
Co-authored-by: Vineet  Mittal <46945843+vmittal-msft@users.noreply.github.com>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
…PE-B-O128 and update comments (sonic-net#24774)

Why I did it
This PR is addressing a comment in sonic-net#24578 by correctly set sai_stats_support_mask for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

Signed-off-by: kewei <kewei@arista.com>
Co-authored-by: Vineet  Mittal <46945843+vmittal-msft@users.noreply.github.com>
Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital pushed a commit that referenced this pull request Mar 19, 2026
…PE-B-O128 and update comments (#24774)

Why I did it
This PR is addressing a comment in #24578 by correctly set sai_stats_support_mask for Arista-7060X6-64PE-B-O128.

Note that bit 7 is not needed for Arista-7060X6-16PE-384C-B-O128S2 as srv6 is not supported for this platform. I just updated the comment for clarity.

Signed-off-by: kewei <kewei@arista.com>
Co-authored-by: Vineet  Mittal <46945843+vmittal-msft@users.noreply.github.com>
Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants