[arp_update] Use parent script PID for logger calls#24569
Closed
theasianpianist wants to merge 1 commit intosonic-net:masterfrom
Closed
[arp_update] Use parent script PID for logger calls#24569theasianpianist wants to merge 1 commit intosonic-net:masterfrom
theasianpianist wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaw in the previous logger implementation in the arp_update script. The change corrects how the process ID is passed to the logger command to ensure proper logging with the parent script's PID, preventing memory issues in rsyslogd.
Key changes:
- Modified the logger function to use
--id="$$"instead of-i "$$"for proper PID specification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The previous fix for this issue #19219 is flawed (see https://github.com/sonic-net/sonic-buildimage/pull/19219/files#r2196157069)
Work item tracking
How I did it
How to verify it
Add a lot of neighbor entries to a device, then delete them manually from APPL_DB. Run the arp_update script and verify that logs are written for each neighbor and that rsyslogd memory usage remains constant.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)