Add support for MIRROR_URL build attribute#24510
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9a81c60 to
d83f6e3
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d83f6e3 to
88a3945
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
88a3945 to
f3342f8
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
f3342f8 to
d1e4096
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
be643e5 to
9c4bd85
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9294279 to
0bfd53c
Compare
|
/azp run Azure.sonic-buildimage |
a8a6f31 to
2933e58
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/lldpd/Makefile
Outdated
| @@ -5,7 +5,7 @@ SHELL = /bin/bash | |||
| MAIN_TARGET = $(LLDPD) | |||
| DERIVED_TARGETS = $(LIBLLDPCTL) $(LLDPD_DBG) | |||
|
|
|||
| LLDP_URL = https://packages.trafficmanager.net/public/debian/pool/main/l/lldpd | |||
| LLDP_URL = $(MIRROR_URL)/public/debian/pool/main/l/lldpd | |||
There was a problem hiding this comment.
Should this also be renamed to PACKAGE_MIRROR_URL?
There was a problem hiding this comment.
Thanks. Done.
2933e58 to
8137059
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rules/config
Outdated
| DEBIAN_SNAP_MIRROR_URL ?= http://packages.trafficmanager.net/snapshot | ||
|
|
||
| # PACKAGE_MIRROR_URL - Default package mirror url | ||
| PACKAGE_MIRROR_URL ?= https://packages.trafficmanager.net |
There was a problem hiding this comment.
It's better to use https://packages.trafficmanager.net/public
The following 3 URL are not related. They can share the same domain or not.
http://packages.trafficmanager.net/snapshot (debian snapshot mirror)
https://packages.trafficmanager.net/public (Microsoft backup some files to avoid web file change.)
https://packages.trafficmanager.net/packages (Microsoft hosted to support reproducible build feature.)
There was a problem hiding this comment.
Good to know.
Is the current name of PACKAGE_MIRROR_URL fine for "https://packages.trafficmanager.net/public"? Or Should we use PUBLIC_URL_PREFIX similar to PACKAGE_URL_PREFIX as it exists for "https://packages.trafficmanager.net/packages"?
There was a problem hiding this comment.
BUILD_SNAPSHOT_URL
BUILD_PUBLIC_URL
BUILD_PACKGES_URL
How about these names. It shows that they are not feature related, just for build.
There was a problem hiding this comment.
Sure. Will work on this change.
There was a problem hiding this comment.
Pushed the changes. Please review
Signed-off-by: Pavan Naregundi <[email protected]>
8137059 to
aa29cd2
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Add support for MIRROR_URL build attribute This change adds support for MIRROR_URL as a build parameters to sonic-buildimage. MIRROR_URL can be mirror of https://packages.trafficmanager.net. Signed-off-by: Pavan Naregundi <[email protected]> * Separate Debian snapshot mirror URL from general mirror URL Signed-off-by: Pavan Naregundi <[email protected]> * Revert changes for older debians Signed-off-by: Pavan Naregundi <[email protected]> * Install ca-certificates in pre_run_buildinfo Signed-off-by: Pavan Naregundi <[email protected]> * Change sed delimiter to avoid escape characters Signed-off-by: Pavan Naregundi <[email protected]> * Simplify the certificates install by bypassing peer check Signed-off-by: Pavan Naregundi <[email protected]> * Pass https verify peer as an argument for apt Signed-off-by: Pavan Naregundi <[email protected]> * Add changes for docker-base-trixie Signed-off-by: Pavan Naregundi <[email protected]> * Rename to all URL to BUILD_<suffix>_URL Signed-off-by: Pavan Naregundi <[email protected]> --------- Signed-off-by: Pavan Naregundi <[email protected]> Co-authored-by: Lihua Yuan <[email protected]> Signed-off-by: Feng Pan <[email protected]>
* Add support for MIRROR_URL build attribute This change adds support for MIRROR_URL as a build parameters to sonic-buildimage. MIRROR_URL can be mirror of https://packages.trafficmanager.net. Signed-off-by: Pavan Naregundi <[email protected]> * Separate Debian snapshot mirror URL from general mirror URL Signed-off-by: Pavan Naregundi <[email protected]> * Revert changes for older debians Signed-off-by: Pavan Naregundi <[email protected]> * Install ca-certificates in pre_run_buildinfo Signed-off-by: Pavan Naregundi <[email protected]> * Change sed delimiter to avoid escape characters Signed-off-by: Pavan Naregundi <[email protected]> * Simplify the certificates install by bypassing peer check Signed-off-by: Pavan Naregundi <[email protected]> * Pass https verify peer as an argument for apt Signed-off-by: Pavan Naregundi <[email protected]> * Add changes for docker-base-trixie Signed-off-by: Pavan Naregundi <[email protected]> * Rename to all URL to BUILD_<suffix>_URL Signed-off-by: Pavan Naregundi <[email protected]> --------- Signed-off-by: Pavan Naregundi <[email protected]> Co-authored-by: Lihua Yuan <[email protected]> Signed-off-by: dprital <[email protected]>
This change adds support for BUILD_PUBLIC_URL and BUILD_SNAPSHOT_URL as a build parameters to sonic-buildimage.
BUILD_SNAPSHOT_URL can be any mirror of https://snapshot.debian.org/archive or http://packages.trafficmanager.net/snapshot
BUILD_PUBLIC_URL can be any mirror of https://packages.trafficmanager.net/public
BUILD_PACKAGES_URL can be any mirror of https://packages.trafficmanager.net/packages
Why I did it
Work item tracking
How I did it
How to verify it
Changes are verified with alternative local mirror of packages.trafficmanager.net.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)