Skip to content

Enhance lldpd.conf.j2 for IPv6 support#24468

Merged
kperumalbfn merged 1 commit intomasterfrom
abdosi-lldpv6
Mar 14, 2026
Merged

Enhance lldpd.conf.j2 for IPv6 support#24468
kperumalbfn merged 1 commit intomasterfrom
abdosi-lldpv6

Conversation

@abdosi
Copy link
Contributor

@abdosi abdosi commented Nov 7, 2025

What I did:
Added support for parsing MGMT interface for ipv6 address also.
With this we will first try ipv4 address as system management ip and than fallback to ipv6.
Alias will be used if any of ip address is present.

Why I did:
Without parsing ipv6 address in ipv6 only network mgmt port alias does not geta advertised.

How I verify:
Manual Verification

@abdosi abdosi requested a review from lguohan as a code owner November 7, 2025 18:40
Copilot AI review requested due to automatic review settings November 7, 2025 18:40
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Nov 7, 2025

@arlakshm : this need cherry-pick for msft 202405.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds IPv6 support to the LLDP daemon configuration template by enabling IPv6 management interface configuration alongside the existing IPv4 support.

  • Adds IPv6 address extraction from management interfaces
  • Implements conditional logic to configure management IP pattern for IPv6-only or IPv4+IPv6 scenarios
  • Prioritizes IPv4 over IPv6 when both are present

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui added the P0 Priority of the issue label Nov 26, 2025
@rlhui rlhui requested a review from mlok-nokia November 26, 2025 04:16
@rlhui
Copy link
Contributor

rlhui commented Nov 26, 2025

@abdosi is this a test gap? please raise a test issue, thanks.

@rlhui rlhui requested a review from arlakshm November 26, 2025 18:09
@rlhui
Copy link
Contributor

rlhui commented Dec 6, 2025

@abdosi - this is a generic issue applicable to all sonic roles right

@judyjoseph
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@abdosi
Copy link
Contributor Author

abdosi commented Jan 14, 2026

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mlok-nokia
mlok-nokia previously approved these changes Feb 11, 2026
Copy link
Contributor

@mlok-nokia mlok-nokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

anamehra
anamehra previously approved these changes Feb 11, 2026
Copy link
Contributor

@anamehra anamehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kenneth-arista
kenneth-arista previously approved these changes Feb 11, 2026
Copy link
Collaborator

@kenneth-arista kenneth-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copilot AI review requested due to automatic review settings February 23, 2026 20:10
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@abdosi abdosi dismissed stale reviews from mlok-nokia, kenneth-arista, and anamehra via b9d7edf March 9, 2026 22:03
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Add support for IPv6 management interface configuration.

Signed-off-by: abdosi <58047199+abdosi@users.noreply.github.com>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn
Copy link
Contributor

@abdosi do we have sonic-mgmt test?

@kperumalbfn kperumalbfn merged commit 836657c into master Mar 14, 2026
21 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-buildimage-msft#2066

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #26179

@abdosi abdosi deleted the abdosi-lldpv6 branch March 14, 2026 02:17
yue-fred-gao pushed a commit to yue-fred-gao/sonic-buildimage that referenced this pull request Mar 16, 2026
Enhance lldpd.conf.j2 for IPv6 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status
Status: Done

Development

Successfully merging this pull request may close these issues.