Skip to content

[yang-model] support reserving mem in high region for crashkernel#24441

Open
ysmanman wants to merge 11 commits intosonic-net:masterfrom
ysmanman:crashkernel-offset
Open

[yang-model] support reserving mem in high region for crashkernel#24441
ysmanman wants to merge 11 commits intosonic-net:masterfrom
ysmanman:crashkernel-offset

Conversation

@ysmanman
Copy link
Contributor

@ysmanman ysmanman commented Nov 5, 2025 •
edited
Loading

Why I did it

By default, crashekernel is reserved in low mem region used by DMA. Support reserving high mem region for crashkernel to avoid occupying DMA mem.

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • [x ] 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ysmanman ysmanman requested a review from lguohan as a code owner November 5, 2025 19:06
@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 5, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 5, 2025

@kenneth-arista @deepak-singhal0408 @YatishSVC @arlakshm

@deepak-singhal0408
Copy link
Contributor

deepak-singhal0408 commented Nov 5, 2025

@ysmanman can you update the testings done with this change.

@arlakshm
Copy link
Contributor

arlakshm commented Nov 5, 2025

@ysmanman do we need to update the yang model?

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 5, 2025

@ysmanman can you update the testings done with this change.

Sure @deepak-singhal0408 Will do.

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 5, 2025

@ysmanman do we need to update the yang model?

Hi @arlakshm good point. I saved the new kdump config in configDb file, and then did config reload. The config reload went through without any issue. config-reload should validate config against yang model, right?

@ysmanman ysmanman requested a review from qiluo-msft as a code owner November 6, 2025 19:44
@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 6, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

deepak-singhal0408
deepak-singhal0408 reviewed Nov 6, 2025
View reviewed changes
src/sonic-yang-models/yang-models/sonic-kdump.yang Outdated
leaf memory {
type string {
pattern "(((([0-9]+[MG]?)?(-([0-9]+[MG])?):)?[0-9]+[MG],?)+)";
pattern "(((([0-9]+[MG]?)?(-([0-9]+[MG])?):)?[0-9]+[MG],?)+(@[0-9]+[MG])?)";
Copy link
Contributor

@deepak-singhal0408 deepak-singhal0408 Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have this optional offset inside the big pattern group(currently this regex only will support offset at the end).. What if in future we want to add offsets at other ranges too..

Copy link
Contributor Author

@ysmanman ysmanman Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Updated the change.

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 6, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

deepak-singhal0408
deepak-singhal0408 previously approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@deepak-singhal0408 deepak-singhal0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks Song.

@deepak-singhal0408
Copy link
Contributor

deepak-singhal0408 commented Nov 7, 2025

@ysmanman please look at the PR checker failure.

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 7, 2025

@ysmanman please look at the PR checker failure.

Sure @deepak-singhal0408 . This is failure. Doesn't look like caused by my change. I will kick off build again.

2025-11-07T03:29:33.3468943Z Error type: RUN_TEST_CASE_FAILED
2025-11-07T03:29:33.3469268Z Error message: route/test_duplicate_route.py|||2 failed for RUN_TEST_CASE_FAILED, stop whole test plan
2025-11-07T03:29:33.3469821Z Operation failed with exception: Exception('Test plan id: 690d4ca98ad8ec69c27e4924, status: FAILED, result: FAILED, Elapsed 5438 seconds. Check ```

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 7, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 7, 2025

Commenter does not have sufficient privileges for PR 24441 in repo sonic-net/sonic-buildimage

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 7, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 7, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 14, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 14, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman ysmanman changed the title Use fixed crashkernel offset Resever mem in high region for crashkernel Nov 14, 2025
@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 24, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 24, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 25, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Contributor Author

ysmanman commented Nov 25, 2025

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 25, 2025

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 26, 2025
Closed
Merged
@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 26, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 26, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 26, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 26, 2025

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Nov 27, 2025
@ysmanman
[msft-202405][yang-model] support reserving mem in high region for cr…
ea028e6 
…ashkernel (#1851)

Why I did it
Cherry-pick sonic-net/sonic-buildimage#24441 in msft-202405.

Work item tracking
Microsoft ADO (number only):
@ysmanman ysmanman mentioned this pull request Nov 27, 2025
Merged
10 tasks
arlakshm pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Nov 28, 2025
@ysmanman
Fix yang model tests in msft-202405 (#1859)
bb76757 
When cherry-pick sonic-net/sonic-buildimage#24441 in msft-202405, Some
typo and mistakes were made in
#1851. Fix them
accordingly.

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@rlhui
Copy link
Contributor

rlhui commented Dec 10, 2025

@ysmanman please rebase? thanks.

@mssonicbld
Copy link
Collaborator

mssonicbld commented Feb 2, 2026

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 2, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Contributor Author

ysmanman commented Feb 3, 2026

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

mssonicbld commented Feb 3, 2026

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 3, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@judyjoseph judyjoseph judyjoseph left review comments

@deepak-singhal0408 deepak-singhal0408 deepak-singhal0408 left review comments

@lguohan lguohan Awaiting requested review from lguohan

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@mlok-nokia mlok-nokia Awaiting requested review from mlok-nokia

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Cherry Pick Conflict_msft-202405 Request for msft-202405 Branch Request for 202511 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ysmanman @mssonicbld @deepak-singhal0408 @arlakshm @rlhui @judyjoseph